config: p2p, fix parsing HostDNS

[iurii-ssv]

Originally this issue was raised by Kraken team, namely they couldn't set HostDNS such that it would work - it would fail with:

2025-01-21T12:58:53.223889Z	FATAL	failed to setup network	{"error": "could not create p2p host: cannot specify multiple address factories", "errorVerbose": "cannot specify multiple address factories\ncould not create p2p host\ngithub.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).SetupHost\n\t/go/src/github.com/ssvlabs/ssv/network/p2p/p2p_setup.go:136\ngithub.com/ssvlabs/ssv/network/p2p.(*p2pNetwork).Setup\n\t/go/src/github.com/ssvlabs/ssv/network/p2p/p2p_setup.go:67\ngithub.com/ssvlabs/ssv/cli/operator.init.func2\n\t/go/src/github.com/ssvlabs/ssv/cli/operator/node.go:445\ngithub.com/spf13/cobra.(*Command).execute\n\t/go/pkg/mod/github.com/spf13/[email protected]/command.go:989\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/go/pkg/mod/github.com/spf13/[email protected]/command.go:1117\ngithub.com/spf13/cobra.(*Command).Execute\n\t/go/pkg/mod/github.com/spf13/[email protected]/command.go:1041\ngithub.com/ssvlabs/ssv/cli.Execute\n\t/go/src/github.com/ssvlabs/ssv/cli/cli.go:27\nmain.main\n\t/go/src/github.com/ssvlabs/ssv/cmd/ssvnode/main.go:20\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:271\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_arm64.s:1222"}
make: *** [Makefile:105: start-node] Error 1
make: *** [docker] Error 2

the root cause was due to them also specifying HostAddress in addition to HostDNS without knowing about it (due to them using our Makefile to start SSV node - with our Makefile defining env variable to set default value for HostAddress), and our code registering both values with libp2p which doesn't tolerate the usage of more than 1

this PR resolves the issue by making sure only one of conflicting p2p settings is used with libp2p prioritizing HostDNS over HostAddress (which seems what we wanna be doing).

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 47.0%. Comparing base (3e76188) to head (b4e8e09).
Report is 7 commits behind head on stage.

Files with missing lines	Patch %	Lines
network/p2p/config.go	22.2%	5 Missing and 2 partials ⚠️

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[moshe-blox]

if you or Kraken can confirm that it works after testing with a real DNS, LGTM :)

[iurii-ssv]

if you or Kraken can confirm that it works after testing with a real DNS, LGTM :)

I've tested locally in Docker to see if it gets us past that error (mentioned in description), and it does - but for real-world setup I'd ask them to confirm (they said they'd like HostDNS eventually, so I'm sure we'll confirm whether it works or not sooner or later).