Add daily vulnerability scan #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gold-kou
reviewed
Oct 27, 2023
.github/workflows/daily-vul-scan.yml
Outdated
| issues: write | ||
|
|
||
| jobs: | ||
| build: |
There was a problem hiding this comment.
I feel the job should be separated more as not only building here.
Such as scanning and making an issue.
There was a problem hiding this comment.
As you suggested, it seemed like a good idea to separate the jobs.
However, upon consideration of the following points, I concluded that processing the trivy results within the same job would be more efficient than writing them out as a string and sharing across different jobs.
- The output of
aquasecurity/trivy-action@masteris specified by file. - The input specification for
JasonEtco/create-an-issue@v2isfilename.
Consequently, I decided to only change the job name, instead of separating the jobs.
There was a problem hiding this comment.
OK, I understand it's tough to separate jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have updated three files for daily vulnerability scan.
daily-vul-scan.ymlREADME.mdtrivy-results.tpl1.
daily-vul-scan.ymlAdd daily vulnerability scan workflow
daily-vul-scan.ymlusing trivy-action created by the official Trivy team.This is the result of a test run.
2.
README.mdAdd a badge to
README.mdto display the workflow results on the main branch.Sample:
The result is marked as failing due to vulnerabilities.
ref. https://github.com/R-HNF/gatling-operator/tree/add_daily-vul-scan
3.
trivy-results.tplAdd a template
trivy-results.tplfor writing out Trivy results to an issue.This is the sample of a test run.
Checklist
Please check if applicable
Relevant issue #45