[EtienneAr Feedback] Add explicit to single argument constructors

stack-of-tasks · Oct 11, 2024 · 52358ed · 52358ed
1 parent f43ba0f
commit 52358ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/include/pinocchio/multibody/joint/joint-mimic.hpp b/include/pinocchio/multibody/joint/joint-mimic.hpp
@@ -168,7 +168,7 @@ namespace pinocchio
     struct TransposeConst
     {
       const ScaledJointMotionSubspaceTpl & ref;
-      TransposeConst(const ScaledJointMotionSubspaceTpl & ref)
+      explicit TransposeConst(const ScaledJointMotionSubspaceTpl & ref)
       : ref(ref)
       {
       }

diff --git a/include/pinocchio/serialization/joints-model.hpp b/include/pinocchio/serialization/joints-model.hpp
@@ -71,7 +71,7 @@ namespace boost
       Derived & joint;
 
     public:
-      SetJointIndexes(Derived & joint)
+      explicit SetJointIndexes(Derived & joint)
       : joint(joint) {};
 
       void run(pinocchio::JointIndex i_id, int i_q, int i_v, int i_j)
@@ -86,7 +86,8 @@ namespace boost
       pinocchio::JointModelMimicTpl<Scalar, Options, JointCollectionTpl> & joint;
 
     public:
-      SetJointIndexes(pinocchio::JointModelMimicTpl<Scalar, Options, JointCollectionTpl> & joint)
+      explicit SetJointIndexes(
+        pinocchio::JointModelMimicTpl<Scalar, Options, JointCollectionTpl> & joint)
       : joint(joint) {};
 
       void run(pinocchio::JointIndex i_id, int i_q, int i_v, int i_j)