Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UserInfoFetcher): Add XFSC AAS backend #519

Merged
merged 39 commits into from
Feb 22, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 7, 2024

Description

To integrade with gaia-x we need to fetch user claims from the AAS. this can be done with the UserInfoFetcher.

part of: https://github.com/stackabletech/marispace-x/issues/55

The integration test contains a small python container that mocks the API.

contains CRD changes, new backend: aas

        clusterConfig:
          userInfo:
            backend:
              aas:
                hostname: aas.$NAMESPACE.svc.cluster.local
                port: 5000

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/main.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/main.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
@fhennig fhennig marked this pull request as ready for review February 12, 2024 16:23
@fhennig fhennig requested review from a team and removed request for a team February 12, 2024 16:25
@fhennig
Copy link
Contributor Author

fhennig commented Feb 13, 2024

@fhennig fhennig requested review from nightkr and a team February 13, 2024 12:43
NickLarsenNZ
NickLarsenNZ previously approved these changes Feb 13, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Left some comments, but pretty much non-blockers.

rust/crd/src/user_info_fetcher.rs Outdated Show resolved Hide resolved
rust/crd/src/user_info_fetcher.rs Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the tests

rust/crd/src/user_info_fetcher.rs Outdated Show resolved Hide resolved
rust/crd/src/user_info_fetcher.rs Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/main.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/main.rs Outdated Show resolved Hide resolved
tests/test-definition.yaml Show resolved Hide resolved
@fhennig
Copy link
Contributor Author

fhennig commented Feb 14, 2024

@nightkr @NickLarsenNZ I still need to fix the test and run it again, but I think code wise everything should be fine. i didn't want to click "Resolve" on the open things, I wanted to leave it to you.

Edit: new test run 🟢

rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a complete review

rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
rust/user-info-fetcher/src/backend/xfsc_aas.rs Outdated Show resolved Hide resolved
@fhennig fhennig requested review from sbernauer and nightkr February 19, 2024 10:51
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM. Did not run the tests myself. Ticked docs since I agree with not documenting this while it's experimental.

tests/test-definition.yaml Outdated Show resolved Hide resolved
@fhennig fhennig added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit fde6c54 Feb 22, 2024
30 checks passed
@fhennig fhennig deleted the feat/userinfofetcher-aas-backend branch February 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants