-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UserInfoFetcher): Add XFSC AAS backend #519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one. Left some comments, but pretty much non-blockers.
tests/templates/kuttl/aas-user-info/30-prepare-test-regorule.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the tests
Co-authored-by: Nick <[email protected]>
@nightkr @NickLarsenNZ I still need to fix the test and run it again, but I think code wise everything should be fine. i didn't want to click "Resolve" on the open things, I wanted to leave it to you. Edit: new test run 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not a complete review
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely LGTM. Did not run the tests myself. Ticked docs since I agree with not documenting this while it's experimental.
Description
To integrade with gaia-x we need to fetch user claims from the AAS. this can be done with the UserInfoFetcher.
part of: https://github.com/stackabletech/marispace-x/issues/55
The integration test contains a small python container that mocks the API.
contains CRD changes, new backend: aas
Definition of Done Checklist
Author
Reviewer
Acceptance