Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Allow binary content to be returned from PHP #34

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

joelbarnard
Copy link

To return Binary content through the ALB, it needs to be Base64 Encoded and the isBase64Encoded flag needs to be set to true.

This change Base64 encodes all responses, and sets the isBase64Encoded flag to true, so that both plaintext and binary responses work.

To return Binary content through the ALB, it needs to be Base64 Encoded and the isBase64Encoded flag needs to be set to true.
Copy link
Member

@txase txase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful, though it has an issue in that it will base64 encode a lot of things that don't need it. Can we validate whether the body is invalid utf-8 first, and only then encode it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants