Synchronise 2023.1 with upstream #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This patch fixes to use correct pool number for a secondary storage on GAD environment[*1]. Even though the option ``hitachi_mirror_pool`` is to set pool number for secondary storage, the option does not work and a pool number for primary storage would be used on secondary storage. The bug should be fixed and delete the risk to be used unexpected pool number. [1] GAD is the storage mirroring product on Hitachi storage. The feature was implied as the patch https://review.opendev.org/c/openstack/cinder/+/796170 and was merged into Antelope. Closes-Bug: #2011810 Change-Id: I9c37ada5e6af1f3c28ebd5c3c2a8baf2d88d0a96 (cherry picked from commit 2270611) (cherry picked from commit 19540c1)
Host group[1] name formats, which is managed by cinder driver, for each storage models must be: ``HBSD-xxx`` for Hitachi storage(``xxx`` is WWPN of target host on FC, or IP address of target host) ``HPEXP-xxx`` for HPE-XP storage ``NEC-xxx`` for NEC V storage , but the format `HBSD-xxx` is used for OEM storage models because a bug in the merged patch https://review.opendev.org/c/openstack/cinder/+/866526 overwrites the prefix for Hitachi storage. It should be fixed to use original prefixes. [1] ``Host group``(or ``iSCSI target``), which is one of Hitachi and OEM storage parameter, is a group of multiple server hosts connecting to same storage port. Following site would be help to know what host group is: https://knowledge.hitachivantara.com/Documents/Management_Software/SVOS/9.1.x/Volume_Management_-_VSP_G130%2C_G%2F%2FF350%2C_G%2F%2FF370%2C_G%2F%2FF700%2C_G%2F%2FF900/Provisioning/11_About_LUN_Manager%2C_logical_units_(LUs)%2C_and_host_groups Closes-Bug: #2012515 Change-Id: I1c9677112caa0808dff17cbde2db6afbe25a2129 (cherry picked from commit 61e7d1f) (cherry picked from commit e8e24a2)
This patch is to fix an exception name when deleted volume is busy in delete_volume(). Although exception ``VolumeIsBusy`` should be issued in that case, ``VolumeDriverException`` is issued. It should be fixed. Closes-Bug: #2024418 Change-Id: I5405790c7cd4ca513ceea70380be723a54c3fe3c (cherry picked from commit a0d0752) (cherry picked from commit 8f497c1)
This patch stops submitting frequently REST API request in test scripts, to avoid a risk of failing the scripts by unexpected REST API response from a psuedo REST API in the scripts. Hitachi driver submits a REST API request frequently, to avoid REST API session timeout. it should be stopped while running test scripts, or the request bothers REST APIs which is for cinder features, like creating volume and delete snapshots. The test scripts have codes to stop submitting, but one of the code does not work by using incorrect variable. The patch fix the variable name to stop that correctoly. Closes-Bug: #2063317 Change-Id: I81090aee4ed6c288f7d9bbdb45d7cc849663e393 (cherry picked from commit 60b7062) (cherry picked from commit 070ca24)
This patch prevents to delete a LDEV that is unexpectedly assigned to two or more objects(volumes or snapshots). In the unexpected situation, if ``delete`` command for one of objects is run again, the data which is used by other objects is lost. In order to prevent the data-loss, when creating an object, the driver creates a LDEV and stores a value obtained by omitting the hyphen from the object ID(*1) to ``LDEV nickname``. When deleting an object, the driver compares the own object ID and the object ID in ``LDEV nickname``, then, the object and the LDEV is deleted only if both object IDs are same. On the other hand, if both object IDs are not same, only the object is deleted and the LDEV is kept, to prevent data-loss. If format of ``LDEV nickname`` is not object ID(*2), both the object and the LDEV is deleted without comparison, because it avoids disk full risk, due to not deleting any LDEVs. This patch implements only the object ID storing while creating a snapshot and comparing IDs while deleting, because the feature to store the object ID while creating a volume has already been implemented. (*1) Max length of ``LDEV nickname`` is 32 digits characters on Hitachi storage. (*2) 32 digits hexadecimal Closes-Bug: #2072317 Change-Id: I7c6bd9a75dd1d7165d4f8614abb3d59fa642212d (cherry picked from commit d04db6f) Conflicts: doc/source/configuration/block-storage/drivers/hitachi-vsp-driver.rst (cherry picked from commit 06f367c)
…nto stable/2023.1
In some deployments, after an upgrade, we remove the old service records and create new ones. This leaves the volumes with the service_uuid pointing to the old (deleted) service and causes an issue while purging out the deleted service records. This patch adds a cinder-manage command to update the service_uuid field of volumes with the following command: ``cinder-manage volume update_service`` The service_uuid of volumes associated with old service_uuid also gets updated when cinder creates a new service. Change-Id: I0b13c6351733b8163bcf6e73c939c375493dcba5 (cherry picked from commit edeac13) (cherry picked from commit 530376b) (cherry picked from commit 5b3717f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2023.1 from upstream stable/2023.1.