Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support muxing fim and chat #343

Merged
merged 6 commits into from
Feb 21, 2025
Merged

feat: support muxing fim and chat #343

merged 6 commits into from
Feb 21, 2025

Conversation

peppescg
Copy link
Collaborator

Add matcher_type select for supporting muxing fim and chat.

Kapture.2025-02-20.at.16.37.35.mp4

@peppescg peppescg self-assigned this Feb 20, 2025
Copy link

stacklok-cloud-staging bot commented Feb 20, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of b4b8fa55:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

@peppescg
Copy link
Collaborator Author

cc @danbarr I think we need to add the fim, chat support to the doc

@peppescg peppescg linked an issue Feb 20, 2025 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13457368919

Details

  • 18 of 20 (90.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 69.62%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/workspace/hooks/use-muxing-rules-form-workspace.ts 5 7 71.43%
Totals Coverage Status
Change from base Build 13436448988: 0.2%
Covered Lines: 862
Relevant Lines: 1176

💛 - Coveralls

@peppescg peppescg merged commit 14b1b2d into main Feb 21, 2025
8 checks passed
@peppescg peppescg deleted the issues/319 branch February 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Muxing v3 fim and chat support
3 participants