-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIKitBackend] UIViewControllerRepresentable
and iPad-only split views
#104
Open
bbrk24
wants to merge
7
commits into
stackotter:main
Choose a base branch
from
bbrk24:UIViewControllers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
183aecd
Initial work supporting controllers
bbrk24 8243bc4
Implement UIViewControllerRepresentable
bbrk24 3e4d3a7
iPad-only split views
bbrk24 9594a0b
final fixes
bbrk24 05ae690
Explain ContainerWidget
bbrk24 e67b054
oops, forgot that
bbrk24 246c69d
Address initial PR comments
bbrk24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
import UIKit | ||
|
||
#if os(iOS) | ||
final class SplitWidget: WrapperControllerWidget<UISplitViewController>, | ||
UISplitViewControllerDelegate | ||
{ | ||
var resizeHandler: (() -> Void)? | ||
private let sidebarContainer: ContainerWidget | ||
private let mainContainer: ContainerWidget | ||
|
||
init(sidebarWidget: some WidgetProtocol, mainWidget: some WidgetProtocol) { | ||
// UISplitViewController requires its children to be controllers, not views | ||
sidebarContainer = ContainerWidget(child: sidebarWidget) | ||
mainContainer = ContainerWidget(child: mainWidget) | ||
|
||
super.init(child: UISplitViewController()) | ||
|
||
child.delegate = self | ||
|
||
child.preferredDisplayMode = .oneBesideSecondary | ||
child.preferredPrimaryColumnWidthFraction = 0.3 | ||
|
||
child.viewControllers = [sidebarContainer, mainContainer] | ||
} | ||
|
||
override func viewDidLoad() { | ||
NSLayoutConstraint.activate([ | ||
sidebarContainer.view.leadingAnchor.constraint( | ||
equalTo: sidebarContainer.child.view.leadingAnchor), | ||
sidebarContainer.view.trailingAnchor.constraint( | ||
equalTo: sidebarContainer.child.view.trailingAnchor), | ||
sidebarContainer.view.topAnchor.constraint( | ||
equalTo: sidebarContainer.child.view.topAnchor), | ||
sidebarContainer.view.bottomAnchor.constraint( | ||
equalTo: sidebarContainer.child.view.bottomAnchor), | ||
mainContainer.view.leadingAnchor.constraint( | ||
equalTo: mainContainer.child.view.leadingAnchor), | ||
mainContainer.view.trailingAnchor.constraint( | ||
equalTo: mainContainer.child.view.trailingAnchor), | ||
mainContainer.view.topAnchor.constraint( | ||
equalTo: mainContainer.child.view.topAnchor), | ||
mainContainer.view.bottomAnchor.constraint( | ||
equalTo: mainContainer.child.view.bottomAnchor), | ||
]) | ||
|
||
super.viewDidLoad() | ||
} | ||
|
||
override func viewDidLayoutSubviews() { | ||
super.viewDidLayoutSubviews() | ||
resizeHandler?() | ||
} | ||
} | ||
|
||
extension UIKitBackend { | ||
public func createSplitView( | ||
leadingChild: any WidgetProtocol, | ||
trailingChild: any WidgetProtocol | ||
) -> any WidgetProtocol { | ||
precondition( | ||
UIDevice.current.userInterfaceIdiom != .phone, | ||
"NavigationSplitView is currently unsupported on iPhone and iPod touch.") | ||
|
||
return SplitWidget(sidebarWidget: leadingChild, mainWidget: trailingChild) | ||
} | ||
|
||
public func setResizeHandler( | ||
ofSplitView splitView: Widget, | ||
to action: @escaping () -> Void | ||
) { | ||
let splitWidget = splitView as! SplitWidget | ||
splitWidget.resizeHandler = action | ||
} | ||
|
||
public func sidebarWidth(ofSplitView splitView: Widget) -> Int { | ||
let splitWidget = splitView as! SplitWidget | ||
return Int(splitWidget.child.primaryColumnWidth.rounded(.toNearestOrEven)) | ||
} | ||
|
||
public func setSidebarWidthBounds( | ||
ofSplitView splitView: Widget, | ||
minimum minimumWidth: Int, | ||
maximum maximumWidth: Int | ||
) { | ||
let splitWidget = splitView as! SplitWidget | ||
splitWidget.child.minimumPrimaryColumnWidth = CGFloat(minimumWidth) | ||
splitWidget.child.maximumPrimaryColumnWidth = CGFloat(maximumWidth) | ||
} | ||
} | ||
#endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
activate
probably only has to be called once at initialisation, and I'm not entirely certain on this butviewWillLayoutSubviews
probably runs more than once. Could maybe move this toloadView
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I remember, I tried putting it in
loadView
, and it crashed because the view hierarchy was insufficiently assembled at that point. I can double-check if it works inviewDidLoad
, but ultimately activating the same instance ofNSLayoutConstraint
multiple times is harmless.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Moving this to
viewDidLoad
causes the app to crash, withHowever,
updateViewConstraints
also works, is called less frequently, and seems more appropriate, so I'll move it to there.