Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5563] Merge upstream up to the point before dropping support for Ruby 2.7 #3

Merged
merged 101 commits into from
Jan 14, 2025
Merged

[ENG-5563] Merge upstream up to the point before dropping support for Ruby 2.7 #3

merged 101 commits into from
Jan 14, 2025

Conversation

LucasHFS
Copy link

@LucasHFS LucasHFS commented Jan 10, 2025 •
edited by jira bot
Loading

Relates to: ENG-5563

@LucasHFS LucasHFS self-assigned this Jan 10, 2025
@LucasHFS LucasHFS changed the title [ENG-5563] Merge upstream [ENG-5563] Merge upstream up to the point before dropping support for Ruby 2.7 Jan 10, 2025
Mikhail Doronin and others added 27 commits January 10, 2025 17:18
@LucasHFS
Test against ruby 2.7
b0ba91e
@finist @LucasHFS
added 'data' postfix to g-recaptcha-response attribute name
a177e17
@grosser @LucasHFS
v5.4.0
8527459
@finist @LucasHFS
fix verify_recaptcha for v2
eb03833
@grosser @LucasHFS
v5.4.1
91ec22d
@LucasHFS
Expose recaptcha reply to the controller
930d0c5
@grosser @LucasHFS
v5.5.0
14b4d53
@grosser @LucasHFS
changelog
dd05831
@ncs1 @LucasHFS
Fix execute on submit demo example
63e538f 
-Async function version is being generated only when inline_script is true.

-Fix element id
ID generated are structured like "g-recaptcha-response-data-#{action}"
@overchind @LucasHFS
Update outdated link to the source of recaptcha_tags.
a8a7801
@rbarreca @LucasHFS
Clarify that if using v3 -> v2 fallback example
eb086e5 
Took me a bit to realize I needed two separate keys to do v3 -> v2 callback. Adding in site and secret_key to example to clarify that concept.
@timobleeker @LucasHFS
Allow multiple invisible recaptchas on a single page by setting custo…
000faf2 
…m selector
@timobleeker @LucasHFS
Use id as custom selector
b3038c0
@grosser @LucasHFS
v5.6.0
063512d
@gogainda @LucasHFS
Update .travis.yml
28f445b
@gogainda @LucasHFS
Update .travis.yml
5e25217
@Vin0uz @LucasHFS
Adding a table of contents to help find information easily.
9a4044b 
Also, adding a small note about which version is used in the rails setup example.
@Vin0uz @LucasHFS
Add french locale
1b8edfb 
Refers to ambethia#380
@grosser @LucasHFS
GA
b119870
@grosser @LucasHFS
v5.7.0
3a4a388
@Vin0uz @LucasHFS
Fix typo in french locale file
9196fb4
@jcmfernandes @LucasHFS
Add support for the enterprise API
5a1b1d2
@jcmfernandes @LucasHFS
Fix specs
e8e228d 
We can't use Recaptch.with_configuration here because it will set api_server_url
and verify_url back to what's returned by calling those methods on
Recaptcha.configuration when its default is actually nil, and those methods
never return nil.
@jcmfernandes @LucasHFS
Update changelog
1cd7e83
@jcmfernandes @LucasHFS
Linting
d139844
@jcmfernandes @LucasHFS
Update codebase docs
407a38a
@jcmfernandes @LucasHFS
Support reading configuration from an env variable
77b71f4
grosser and others added 20 commits January 10, 2025 17:21
@grosser @LucasHFS
v5.13.0
42c534f
@AndyStabler @LucasHFS
Permit actions as symbol
197e32b 
This commit allows the user to pass in the expected action as a symbol.

Previously we would compare the string action with the symbol action and
we'd think the action was invalid.
@grosser @LucasHFS
v5.13.1
fb49357
@64kramsystem @LucasHFS
Remove explicit json gem dependency
4dac9e1 
This solves problems which have been described in the [tracking issue](ambethia#427).

Closes ambethia#427.
@grosser @LucasHFS
v5.14.0
a54e697
@igor-drozdov @LucasHFS
Add 3.2 to the list of Ruby versions
b596bc0
@igor-drozdov @LucasHFS
Update CHANGELOG.md
f85154c
@shrmnk @LucasHFS
Add json option to submit reCAPTCHA server verification URL as POST…
04a41ea 
… request with JSON

Certain reCAPTCHA-compatible services require that the server verification be submitted via POST rather than GET.

An example is Cloudflare Turnstile:
https://developers.cloudflare.com/turnstile/migration/migrating-from-recaptcha/#server-side-integration

That documentation calls out the requirement for the verification call be done via POST.

This PR adds the ability to supply options[:json] = true (defaults to false) to submit the data as POST with JSON body.
@shrmnk @LucasHFS
Update README.md to indicate json option in verify_recaptcha
3177d0a
@shrmnk @LucasHFS
Update CHANGELOG.md to reflect new options[:json]
9717f3c
@grosser @LucasHFS
v5.15.0
513c1a8
@NARKOZ @LucasHFS
Improve documentation for action names per documentation
419bbb7 
See: https://cloud.google.com/recaptcha-enterprise/docs/actions
@LucasHFS
Allow the use of turbo to enable turbo functionality
7f39bbd
@LucasHFS
Add changelog entry
6355b40
@LucasHFS
Update changelog
16a0055
@grosser @LucasHFS
v5.16.0
072b4a2
@Tom-Boyd @LucasHFS
Add key setup to v3 example in README
7aea7f1
@Tom-Boyd @LucasHFS
Update CHANGELOG
bcc1e66
@jcoyne @LucasHFS
Remove unnecessary id
78b1d44 
This was unused and may cause accessibility concerns if there is more than one recaptcha on the page due to multiple elements with the same id
@jcoyne @LucasHFS
Update rubocop
9356767
@LucasHFS LucasHFS merged commit 7b0c267 into master Jan 14, 2025
0 of 7 checks passed
@LucasHFS LucasHFS deleted the merge-upstream branch January 14, 2025 18:36
@LucasHFS LucasHFS restored the merge-upstream branch January 14, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samflores samflores samflores approved these changes

@marmitoTH marmitoTH marmitoTH approved these changes

@symbolboxer symbolboxer Awaiting requested review from symbolboxer

@HeitorMC HeitorMC Awaiting requested review from HeitorMC

Assignees

@LucasHFS LucasHFS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.