Unit test to demonstrate onpopstate failure when navigating very quickly #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y quickly after first router initialisation.
|
Additionally when testing in my use case scenario - if the document had not entered the 'complete' readystate before the router init() method had been called, the onDOMReady function was never called because the wrong event name for the addEventListener function had been used. See latest commit for the fix. Unfortunately it is difficult if not impossible to test the event handlers are successfully being subscribed owing to the fact that the html5 harness document fully loads before kicking off the unit tests. |
staeke
added a commit
that referenced
this pull request
Jun 26, 2014
Unit test to demonstrate onpopstate failure when navigating very quickly
|
Thanks @benwhite-deltas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test to demonstrate problem for flatiron#229