Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest theme #203

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Latest theme #203

merged 4 commits into from
Nov 14, 2024

Conversation

karl-johan-grahn
Copy link
Contributor

@karl-johan-grahn karl-johan-grahn commented Nov 14, 2024

  • Follow-up from Do PR specific overrides for versioned docs .github#132
    • Add prepare_theme_pr.sh
  • Fetch latest theme, specifically to pick up Update the outdated banner stakater-docs-mkdocs-theme#52
    • Update combine theme script to use arguments
    • Create override for PR builds
  • Fix bug in pull request workflow, apparently the PR Docker image has always been built before the versioned docs have been deployed - it has to be in the reverse order, the docs have to be deployed first on the pull-request-deployments branch before the image can be built based on the content on that branch

In short, the effect this will have is that it will create a PR specific banner for PR deployments, highlighting that it is a PR build.

@karl-johan-grahn karl-johan-grahn requested a review from a team as a code owner November 14, 2024 21:46
Copy link

github-actions bot commented Nov 14, 2024

@stakater-user Image is available for testing. docker pull ghcr.io/stakater/mto-docs:v0.0.165

Copy link

@karl-johan-grahn Image is available for testing. docker pull ghcr.io/stakater/mto-docs:SNAPSHOT-PR-203-16eae394

Copy link

@karl-johan-grahn Image is available for testing. docker pull ghcr.io/stakater/mto-docs:SNAPSHOT-PR-203-b8b5da5a

@rasheedamir rasheedamir merged commit 4a21800 into main Nov 14, 2024
6 checks passed
@rasheedamir rasheedamir deleted the banner-update branch November 14, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants