Skip to content

Commit

Permalink
this removes the public api keys for posthog (#971)
Browse files Browse the repository at this point in the history
  • Loading branch information
kevkevinpal authored Jan 23, 2025
1 parent 0142db0 commit ecd7a8a
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 12 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/build_on_master_merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ jobs:
run: |
docker buildx build \
--cache-to "type=local,dest=/tmp/.buildx-cache" \
--build-arg REACT_APP_PUBLIC_POSTHOG_KEY=${{ secrets.REACT_APP_PUBLIC_POSTHOG_KEY }} \
--build-arg REACT_APP_PUBLIC_POSTHOG_HOST=${{ secrets.REACT_APP_PUBLIC_POSTHOG_HOST }} \
--platform linux/amd64,linux/arm/v7 \
--tag "${{ secrets.DOCKER_HUB_USER }}/sphinx-tribes-frontend:master" \
--output "type=registry" ./
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ jobs:
docker buildx build \
--cache-to "type=local,dest=/tmp/.buildx-cache" \
--platform linux/amd64,linux/arm/v7 \
--build-arg REACT_APP_PUBLIC_POSTHOG_KEY=${{ secrets.REACT_APP_PUBLIC_POSTHOG_KEY }} \
--build-arg REACT_APP_PUBLIC_POSTHOG_HOST=${{ secrets.REACT_APP_PUBLIC_POSTHOG_HOST }} \
--tag "${{ secrets.DOCKER_HUB_USER }}/sphinx-tribes-frontend:${{ env.RELEASE_TAG }}" \
--tag "${{ secrets.DOCKER_HUB_USER }}/sphinx-tribes-frontend:latest" \
--output "type=registry" ./
Expand Down
5 changes: 5 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ COPY yarn.lock ./
RUN yarn install --production

COPY . .
ARG REACT_APP_PUBLIC_POSTHOG_KEY
ARG REACT_APP_PUBLIC_POSTHOG_HOST

ENV REACT_APP_PUBLIC_POSTHOG_KEY=$REACT_APP_PUBLIC_POSTHOG_KEY
ENV REACT_APP_PUBLIC_POSTHOG_HOST=$REACT_APP_PUBLIC_POSTHOG_HOST

RUN yarn run build

Expand Down
7 changes: 0 additions & 7 deletions public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>Sphinx Community</title>
<script>
!function(t,e){var o,n,p,r;e.__SV||(window.posthog=e,e._i=[],e.init=function(i,s,a){function g(t,e){var o=e.split(".");2==o.length&&(t=t[o[0]],e=o[1]),t[e]=function(){t.push([e].concat(Array.prototype.slice.call(arguments,0)))}}(p=t.createElement("script")).type="text/javascript",p.crossOrigin="anonymous",p.async=!0,p.src=s.api_host.replace(".i.posthog.com","-assets.i.posthog.com")+"/static/array.js",(r=t.getElementsByTagName("script")[0]).parentNode.insertBefore(p,r);var u=e;for(void 0!==a?u=e[a]=[]:a="posthog",u.people=u.people||[],u.toString=function(t){var e="posthog";return"posthog"!==a&&(e+="."+a),t||(e+=" (stub)"),e},u.people.toString=function(){return u.toString(1)+".people (stub)"},o="init capture register register_once register_for_session unregister unregister_for_session getFeatureFlag getFeatureFlagPayload isFeatureEnabled reloadFeatureFlags updateEarlyAccessFeatureEnrollment getEarlyAccessFeatures on onFeatureFlags onSessionId getSurveys getActiveMatchingSurveys renderSurvey canRenderSurvey getNextSurveyStep identify setPersonProperties group resetGroups setPersonPropertiesForFlags resetPersonPropertiesForFlags setGroupPropertiesForFlags resetGroupPropertiesForFlags reset get_distinct_id getGroups get_session_id get_session_replay_url alias set_config startSessionRecording stopSessionRecording sessionRecordingStarted captureException loadToolbar get_property getSessionProperty createPersonProfile opt_in_capturing opt_out_capturing has_opted_in_capturing has_opted_out_capturing clear_opt_in_out_capturing debug getPageViewId".split(" "),n=0;n<o.length;n++)g(u,o[n]);e._i.push([i,s,a])},e.__SV=1)}(document,window.posthog||[]);
posthog.init('phc_1UPR3wqvyvLllQJtpecsmaqEfKInrr0WDSPZf0RHODP', {
api_host:'https://us.i.posthog.com',
person_profiles: 'identified_only' // or 'always' to create profiles for anonymous users as well
})
</script>
</head>

<body>
Expand Down
7 changes: 2 additions & 5 deletions src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,15 @@ import '@elastic/eui/dist/eui_theme_dark.css';
import 'bootstrap/dist/css/bootstrap.css';
import { appEnv } from './config/env';

//const options = {
// api_host: process.env.REACT_APP_PUBLIC_POSTHOG_HOST
//};
const options = {
api_host: 'https://us.i.posthog.com'
api_host: process.env.REACT_APP_PUBLIC_POSTHOG_HOST
};

if (appEnv.isTests) {
ReactDOM.render(<App />, document.getElementById('root'));
} else {
ReactDOM.render(
<PostHogProvider apiKey={'phc_1UPR3wqvyvLllQJtpecsmaqEfKInrr0WDSPZf0RHODP'} options={options}>
<PostHogProvider apiKey={process.env.REACT_APP_PUBLIC_POSTHOG_KEY} options={options}>
<App />
</PostHogProvider>,
document.getElementById('root')
Expand Down

0 comments on commit ecd7a8a

Please sign in to comment.