-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local ESS, quantile ESS, ESS change, and rank-based alternative to traceplot #178
Comments
@tjmahr's comments on rank plot
|
@tjmahr, @paul-buerkner, @jgabry suggestions for the function names? |
I think we could also use the
The rank plots could simply be named |
I've been traveling and am just catching up on this. I like the function names suggested by @paul-buerkner |
Related to this issue, we'll also need to update the bayesplot MCMC diagnostics vignette. |
Added to todo list: mcmc_ecdfd_r_scale for ECDF difference plots (see Fig. 14c in SBC paper) |
example of mcmc_ecdfd_r_scale plot |
Thanks Aki |
Would it be possible to add a |
Excellent! Thanks for the heads up. |
Hi all. It looks like there hasn't been any activity here for a while. Is there still interest in pursuing the remaining plot functions from this issue? |
ECDF difference plots were added by #282 |
Would a PR be welcome for those ESS plots that essentially collects the relevant code from @avehtari's reference code (along with tests etc)? Are there some complexities about bayesplot that I'd need to be aware of to make this work? |
Yes! You can make a PR, and Jonah can then provide feedback to take into account the bayesplot requirements |
Edit: Sorry @tjmahr, that I (Aki) hijack this issue.
Implement new plots as described in
See also Dan's blog post
The reference code is available in monitorplot.R
Implement versions of functions
Feel free to come up with better function names, add checks, and it's fine to make separate PRs for these, if you want to implement just one.
For three last ones see also stan-dev/rstan#617
The text was updated successfully, but these errors were encountered: