-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Code Actions under Ruby LSP #636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirm this works locally
…sage we can no longer log
… an attribute definition. For some reason, this particular autofix will cause intermittent build failures and I can't figure out why
6 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 26, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 27, 2024
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Jan 10, 2025
Follow up standardrb/standard#636. Because standardrb/standard#636 alone does not behave as expected in VS Code, this includes the content of the following commits related to the changes in standardrb/standard#636. - standardrb/standard@ab18144 - standardrb/standard@edd199b - standardrb/standard@4240fc5 - standardrb/standard@2fcca8d - standardrb/standard@84ee9f4 This ensures that the features related to standardrb/standard#636 will work, so it is being submitted as an independent commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support code actions (e.g. "Quick Fix" in VS Code), we need a more sophisticated way of invoking RuboCop than our kinda hacky stdin / stdout capture technique that invokes the CLI version. Ruby LSP provides a great way for doing this: extend the base runner and rely on instance variables of the runner to get at the actual RuboCop objects, then translate that to LSP types from the language_server_protocol gem's interfaces.
Lots of thoughts:
Standardizer
object (which the Ruby LSP addon and the built-in server both depend on) is now returning diagnostic objects, whereas the built-instandard --lsp
server is expecting JSON parsed from stdin.That needs to be translated appropriately before shipping anythingDone ✅--lsp
server in favor of pointing people to Ruby LSP and/or delegating to the RuboCop LSP