Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in pinecone integration, add support for using cohere embed with pinecone and create basic example notebook #342

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DanielUH2019
Copy link
Contributor

@DanielUH2019 DanielUH2019 commented Feb 5, 2024

@CShorten , @okhat this should resolve #322. I removed the _init_pinecone function because I believe it shouldn't be the responsibility of the PineconeRM class to create an index. Let me know what you think.

@insop
Copy link
Contributor

insop commented Feb 18, 2024

Thank you for the detailed descriptions of the issue and the fix.
I did a cursory look at it and it looks good to me.

We need to improve this document for other RMs, but if you could add the entry for pinecone, it would be great.

  • docs/retrieval_models_client.md

@DanielUH2019
Copy link
Contributor Author

Hey @insop , I added an entry for pinecone in the docs

@insop
Copy link
Contributor

insop commented Feb 20, 2024

Hey @insop , I added an entry for pinecone in the docs

Thank you so much, looks good to me.

@arnavsinghvi11
Copy link
Collaborator

Hi @DanielUH2019 , could you merge conflicts locally and commit again? seems like I'm unable to do it within the local command line here but the changes are good to merge!

@csellis
Copy link
Contributor

csellis commented May 15, 2024

@DanielUH2019 any updates on addressing the conflicts? facing the same issue with Pinecone
AttributeError: init is no longer a top-level attribute of the pinecone package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Retrieval] Is the PineconeRM functional?
4 participants