fix: update imports to allow global dspy.Google #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, running checks |
|
One minor question, and looks good to me. |
insop
reviewed
Feb 22, 2024
| @@ -8,7 +8,8 @@ | |||
| import google.generativeai as genai | |||
| except ImportError: | |||
| google_api_error = Exception | |||
| print("Not loading Google because it is not installed.") | |||
| # print("Not loading Google because it is not installed.") | |||
There was a problem hiding this comment.
If it stays, we print this every time anybody imports dspy, regardless of whether they are importing Google specifically. It's similar to how imports are managed on the Cohere side in: dsp/modules/cohere.py.
I imagine there may be a cleaner way throughout the project to manage optional dependencies.
|
Running some basic checks then merging |
|
I wish there was an automatic way to tell github "please merge but only if the checks pass" instead of just waiting for the checks. Maybe there is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the new Google LM class, does not have consistent imports with the remainder of the LMs.
ie. dspy.Cohere works, but dspy.Google does not.
This PR makes small import changes to ensure consistency.