Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

Tests for TPCDS queries join ordering #21

Closed
wants to merge 6 commits into from
Closed

Tests for TPCDS queries join ordering #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37c5bbb
Add TPCDS queries to tpcds connector module
kokosing Mar 1, 2018
c4a4ef2
Support TPCDS stats file to store DATE as String
kokosing Mar 1, 2018
a089a70
Add statistics for tpcds.sf3000
kokosing Mar 1, 2018
a20d9e8
Extract BaseJoinReorderingTest
kokosing Mar 1, 2018
6cc67e9
Add TPCDS expected join ordering files
kokosing Mar 1, 2018
a1f880e
Tests for TPCDS queries join ordering
kokosing Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/01.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
cross join:
join (LEFT, REPLICATED):
join (INNER, REPLICATED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these files needed? I thought the idea was that there is no persistent 'expected' value?

Also, include in the cmt msg how the files were generated (technique, what session settings).

Also, name the files .txt to avoid stupid problems like ".join_ordering is an unknown extension" or whatever.

join (INNER, REPLICATED):
tpcds:store_returns:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:store:sf3000.0
join (INNER, REPLICATED):
tpcds:store_returns:sf3000.0
tpcds:date_dim:sf3000.0
values
13 changes: 13 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/02.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
tpcds:web_sales:sf3000.0
tpcds:catalog_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:date_dim:sf3000.0
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
tpcds:web_sales:sf3000.0
tpcds:catalog_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:date_dim:sf3000.0
5 changes: 5 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/03.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
join (INNER, REPLICATED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:item:sf3000.0
tpcds:date_dim:sf3000.0
95 changes: 95 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/04.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:customer:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:customer:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:catalog_sales:sf3000.0
tpcds:date_dim:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:catalog_sales:sf3000.0
tpcds:date_dim:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:web_sales:sf3000.0
tpcds:date_dim:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:web_sales:sf3000.0
tpcds:date_dim:sf3000.0
20 changes: 20 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/05.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
tpcds:store_sales:sf3000.0
tpcds:store_returns:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:store:sf3000.0
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
tpcds:catalog_sales:sf3000.0
tpcds:catalog_returns:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:catalog_page:sf3000.0
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
tpcds:web_sales:sf3000.0
join (RIGHT, PARTITIONED):
tpcds:web_sales:sf3000.0
tpcds:web_returns:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:web_site:sf3000.0
15 changes: 15 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/06.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
cross join:
join (LEFT, REPLICATED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
tpcds:customer_address:sf3000.0
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
join (INNER, REPLICATED):
tpcds:date_dim:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:item:sf3000.0
tpcds:item:sf3000.0
values
9 changes: 9 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/07.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
join (INNER, REPLICATED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:customer_demographics:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:promotion:sf3000.0
tpcds:item:sf3000.0
10 changes: 10 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/08.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:store:sf3000.0
tpcds:customer_address:sf3000.0
join (INNER, PARTITIONED):
tpcds:customer_address:sf3000.0
tpcds:customer:sf3000.0
31 changes: 31 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/09.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
cross join:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep... this is how we handle this query today, see: prestodb#6944

tpcds:store_sales:sf3000.0
tpcds:reason:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
tpcds:store_sales:sf3000.0
23 changes: 23 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/10.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
cross join:
join (RIGHT, PARTITIONED):
join (INNER, REPLICATED):
tpcds:catalog_sales:sf3000.0
tpcds:date_dim:sf3000.0
cross join:
join (RIGHT, PARTITIONED):
join (INNER, REPLICATED):
tpcds:web_sales:sf3000.0
tpcds:date_dim:sf3000.0
cross join:
join (RIGHT, PARTITIONED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
join (INNER, REPLICATED):
tpcds:customer_demographics:sf3000.0
join (INNER, REPLICATED):
tpcds:customer:sf3000.0
tpcds:customer_address:sf3000.0
values
values
values
43 changes: 43 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/11.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:customer:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:customer:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:web_sales:sf3000.0
tpcds:date_dim:sf3000.0
join (INNER, PARTITIONED):
values
join (INNER, PARTITIONED):
values
values
join (INNER, PARTITIONED):
tpcds:customer:sf3000.0
join (INNER, REPLICATED):
tpcds:web_sales:sf3000.0
tpcds:date_dim:sf3000.0
5 changes: 5 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/12.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
tpcds:web_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:item:sf3000.0
11 changes: 11 additions & 0 deletions presto-tpcds/src/test/resources/join_ordering/13.join_ordering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
join (INNER, REPLICATED):
join (INNER, PARTITIONED):
join (INNER, REPLICATED):
join (INNER, REPLICATED):
join (INNER, REPLICATED):
tpcds:store_sales:sf3000.0
tpcds:date_dim:sf3000.0
tpcds:customer_address:sf3000.0
tpcds:household_demographics:sf3000.0
tpcds:customer_demographics:sf3000.0
tpcds:store:sf3000.0
Loading