Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the api and much more #302

Merged
merged 83 commits into from
Nov 17, 2023
Merged

Update the api and much more #302

merged 83 commits into from
Nov 17, 2023

Conversation

Thorinwasher
Copy link

Refactor of the api necessary to facilitate more advanced interaction between modules and portals.

  • Add interface for registiring/unregestiring portal positions protected by stargate
  • Add interface for removing/adding portals
  • Add builders for portals and gates
  • Add interface for creating networks
  • Modify source code to be able to do the above changes

@Thorinwasher
Moved most api related stuff to the api package
fd8b116
@Thorinwasher
.
fb43aaa
@Thorinwasher
Moves some stuff and adds some interfaces / enums
963da7a 
For example BlockInterfaceHandler and a Priority enum
@Thorinwasher
Adds logic for removing and adding BlockHandlerInterfaces
3ed9c83
@Thorinwasher
Changes how blockHandlerInterfaces are dealt with also...
d930f1b 
Adds unittest to test that (Does not pass at the moment)
@Thorinwasher
Adds some tests to Gate
7327552
@Thorinwasher
Update StargateRegistryTest.java
9da3699
@Thorinwasher
Update BlockEventListenerTest.java
74d3184
@Thorinwasher
Fixes some security issues with dependencies
c27dd34
@Thorinwasher
Adds some unittests
a8717b8
@Thorinwasher
Allows for unrecognised flags ( I think )
b5bf545 
Probably needs some testing as well.

Also split PortalData into two different classes
@Thorinwasher
fixes some test failures
de01ff2
@Thorinwasher
Fixes the all unittests
3cd8ea3
@Thorinwasher
(just a small refactor)
14ee1dc
@Thorinwasher
Clears up and renames stuff
00b91ce
@Thorinwasher
Increases the scale of some tests
8659ecd
@Thorinwasher
Adds more tests
1581db0
@Thorinwasher
Inserts a new column in the portal position table
05f26ee
@Thorinwasher
Fixes a severe infinite loop issue and sql issues
bc11f90
@Thorinwasher
Fixes unit tests
46708d6
@Thorinwasher
Fixes startup issue
acf2ec6
@Thorinwasher
fix: MaterialHandlerResolver not initialized
d8a0246
@Thorinwasher
rename MaterialHandlerResolver -> BlockHandlerResolver
dff211b
@Thorinwasher
Does a lot which can't be described in one line
291fcc9
@Thorinwasher
Fixes a bug in a unittest.
64e8e10
@Thorinwasher
Nothing special
dbb4149
@Thorinwasher
Moved some classes
5631fca
@Thorinwasher
Refactored StargateRegistry to store HashMaps of portalPositions
5ef4b9e
@Thorinwasher
Fixes unit tests
0b7e264
@Thorinwasher
Fixes a bug where intruducing new sign material breaks coloring
a454b41
@Thorinwasher
Minor fix
df2f4c1
@Thorinwasher
Removes null SignLines for fixed portals
86b9cd7
@Thorinwasher
Add and remove flags from portal without modifying storage
c7de0f3
@Thorinwasher
Clarifications
56a8399
@Thorinwasher
Adds a new event
8573e1f
@Thorinwasher
Moved BypassPermission to the api
1f31703
@Thorinwasher
Implement new event, made to move the flag Q from core
eefedb7
@Thorinwasher
Adds more places to throw StargateSendMessagePortalEvent
4dd4659
@Thorinwasher
Untested code for generating gate structures
fae6610
@Thorinwasher
Adds a test for generating structures
dc20ffb
@Thorinwasher
Minor refactor on the StargateOpenPortalEvent
4df6f9a 
Should now allow for destination overrides
@Thorinwasher
Ignores flag arguments when determining flags
220caf2
@Thorinwasher
Add gateformat registry
9edf9b2
@Thorinwasher
Refactor portal and gate creation
bdd19b4
@Thorinwasher
Fixes getNetworkManager returning null
937f588
@Thorinwasher
Fixes invalid button generation from alwayson flag
8cf9785
@Thorinwasher
Minor modifications on explicitgatebuilder
796612a
@Thorinwasher
Properly closes connections
964efaf
@Thorinwasher
Move GateStructure and expose methods
0b8fefa
@Thorinwasher
Saves metadata from create event
b2020de
@Thorinwasher
Load metadata on start up
a10d94f
@Thorinwasher
Major refactor on network and portal handling
26dc36b
@Thorinwasher
Fix unit tests
fdf393f
@Thorinwasher
Update GateFrame.java
258b61c
@Thorinwasher
Update GateFrame.java
160772e
@Thorinwasher Thorinwasher linked an issue Nov 17, 2023 that may be closed by this pull request
The API Update #289
Closed
6 tasks
@ghost

This comment was marked as resolved.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 17, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 50 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@Pheotis Pheotis merged commit f466aaa into nightly Nov 17, 2023
3 of 4 checks passed
@Pheotis Pheotis deleted the apiv2 branch November 17, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The API Update
2 participants
@Thorinwasher @Pheotis