refactor(execution): make the block state of TransactionExecutor an O…

[barak-b-starkware]

…ption to allow moving it to chunks

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.17%. Comparing base (a34e203) to head (e275fb3).

Files	Patch %	Lines
.../blockifier/src/blockifier/transaction_executor.rs	52.63%	9 Missing ⚠️
...es/blockifier/src/blockifier/stateful_validator.rs	85.71%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1947      +/-   ##
==========================================
- Coverage   78.18%   78.17%   -0.02%     
==========================================
  Files          62       62              
  Lines        8820     8842      +22     
  Branches     8820     8842      +22     
==========================================
+ Hits         6896     6912      +16     
- Misses       1486     1492       +6     
  Partials      438      438              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[noaov1]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware, @barak-b-starkware, and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/stateful_validator.rs line 113 at r1 (raw file):

        let charge_fee = true;
        tx.perform_pre_validation_stage(
            self.tx_executor.block_state.as_mut().expect("The block state should be `Some`."),

Consider defining a getter:
(you may also need a non-mutable reference)

Code quote (i):

          self.tx_executor.block_state.as_mut().expect("The block state should be `Some`."),

Code snippet (ii):

    pub fn mutable_block_state<'a>(&'a mut self) -> &'a mut CachedState<S> {
        self.block_state.as_mut().expect("The block state should be `Some`.")
    }

---

crates/blockifier/src/blockifier/transaction_executor.rs line 50 at r1 (raw file):

    // The transaction executor operates at the block level. It moves the block's state when
    // operating at the chunk level and gets it back after the chunk is committed, so it needs to
    // be wrapped with an Option<_>.

Suggestion:

    // The transaction executor operates at the block level. In the concurrent mpode, it moves the 
    // block's state when operating at the chunk level and gets it back after the chunk is committed, 
    // so it needs to be wrapped with an Option<_>.

[avi-starkware]

crates/blockifier/src/blockifier/transaction_executor.rs line 50 at r1 (raw file):

    // The transaction executor operates at the block level. It moves the block's state when
    // operating at the chunk level and gets it back after the chunk is committed, so it needs to
    // be wrapped with an Option<_>.

Suggestion:

    // The transaction executor operates at the block level. In concurrency mode, it moves the block state to the worker executor 
    // - operating at the chunk level - and gets it back after committing the chunk. The block state is 
    // wrapped with an Option<_> to allow setting it to `None` while it is moved to the worker executor.

[avi-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @barak-b-starkware and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 177 at r1 (raw file):

        self.block_state
            .as_mut()
            .expect("The block state should be `Some`.")

Define a const with this error message. (Unless you define a getter as Noa suggested above.

Code quote:

"The block state should be `Some`."

[barak-b-starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @avi-starkware, @MohammadNassar1, @OriStarkware, and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 50 at r1 (raw file):

    // The transaction executor operates at the block level. It moves the block's state when
    // operating at the chunk level and gets it back after the chunk is committed, so it needs to
    // be wrapped with an Option<_>.

Done.

---

crates/blockifier/src/blockifier/transaction_executor.rs line 50 at r1 (raw file):

    // The transaction executor operates at the block level. It moves the block's state when
    // operating at the chunk level and gets it back after the chunk is committed, so it needs to
    // be wrapped with an Option<_>.

Done. Took @avi-starkware 's suggestion that expands yours a little bit.

[avi-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware, @MohammadNassar1, @OriStarkware, and @Yoni-Starkware)

[noaov1]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @barak-b-starkware, @MohammadNassar1, @OriStarkware, and @Yoni-Starkware)

[barak-b-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @MohammadNassar1, @OriStarkware, and @Yoni-Starkware)

---

crates/blockifier/src/blockifier/stateful_validator.rs line 113 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Consider defining a getter:
(you may also need a non-mutable reference)

Done. @avi-starkware 's suggestion.

---

crates/blockifier/src/blockifier/transaction_executor.rs line 177 at r1 (raw file):

Previously, avi-starkware wrote…

Define a const with this error message. (Unless you define a getter as Noa suggested above.

Done.

[avi-starkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1, @OriStarkware, and @Yoni-Starkware)

[noaov1]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1, @OriStarkware, and @Yoni-Starkware)

[Yoni-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1 and @OriStarkware)

[OriStarkware]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)

[noaov1]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MohammadNassar1)