chore: clean fee utils

[Yoni-Starkware]

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.25%. Comparing base (702f401) to head (a5ff62f).
Report is 2 commits behind head on main.

Files	Patch %	Lines
crates/blockifier/src/fee/actual_cost.rs	80.00%	0 Missing and 1 partial ⚠️
crates/blockifier/src/test_utils/struct_impls.rs	90.90%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   78.17%   78.25%   +0.07%     
==========================================
  Files          62       62              
  Lines        8842     8865      +23     
  Branches     8842     8865      +23     
==========================================
+ Hits         6912     6937      +25     
  Misses       1492     1492              
+ Partials      438      436       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dorimedini-starkware]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/test_utils.rs line 455 at r1 (raw file):

        .to_gas_vector(&block_context.versioned_constants, block_context.block_info.use_kzg_da)?;
    Ok(get_fee_by_gas_vector(&block_context.block_info, gas_vector, fee_type))
}

make this a method of TransactionResources please, next to to_gas_vector

Code quote:

pub fn calculate_tx_fee(
    tx_resources: &TransactionResources,
    block_context: &BlockContext,
    fee_type: &FeeType,
) -> TransactionFeeResult<Fee> {
    let gas_vector = tx_resources
        .to_gas_vector(&block_context.versioned_constants, block_context.block_info.use_kzg_da)?;
    Ok(get_fee_by_gas_vector(&block_context.block_info, gas_vector, fee_type))
}

[Yoni-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)

---

crates/blockifier/src/test_utils.rs line 455 at r1 (raw file):

Previously, dorimedini-starkware wrote…

make this a method of TransactionResources please, next to to_gas_vector

Why? It is used only in tests.
Or did you mean to put it under test config?

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/test_utils.rs line 455 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why? It is used only in tests.
Or did you mean to put it under test config?

I would simply like all fee manipulation logic to be encapsulated in one object, instead of many utilities floating around without context.
maybe add an impl TransactionResources block in a test_utils module, with this function?

[Yoni-Starkware]

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)

---

crates/blockifier/src/test_utils.rs line 455 at r1 (raw file):

Previously, dorimedini-starkware wrote…

I would simply like all fee manipulation logic to be encapsulated in one object, instead of many utilities floating around without context.
maybe add an impl TransactionResources block in a test_utils module, with this function?

Done.

[dorimedini-starkware]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)