fix(transaction): remove charge fee flag from the transaction executo…

[meship-starkware]

…r execute

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (cefb2a2) to head (99df797).

Files	Patch %	Lines
crates/native_blockifier/src/py_block_executor.rs	0.00%	2 Missing ⚠️
...es/blockifier/src/blockifier/stateful_validator.rs	0.00%	0 Missing and 1 partial ⚠️
.../blockifier/src/blockifier/transaction_executor.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1970      +/-   ##
==========================================
+ Coverage   78.35%   78.38%   +0.03%     
==========================================
  Files          62       62              
  Lines        8861     8855       -6     
  Branches     8861     8855       -6     
==========================================
- Hits         6943     6941       -2     
+ Misses       1479     1475       -4     
  Partials      439      439              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[OriStarkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[noaov1]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 113 at r1 (raw file):

        &mut self,
        txs: &[Transaction],
        charge_fee: bool,

Can be removed.

Code quote:

        charge_fee: bool,

---

crates/blockifier/src/blockifier/transaction_executor.rs line 120 at r1 (raw file):

            txs.chunks(self.config.concurrency_config.chunk_size)
                .fold_while(Vec::new(), |mut results, chunk| {
                    let chunk_results = self.execute_chunk(chunk, charge_fee);

Suggestion:

 let chunk_results = self.execute_chunk(chunk);

---

crates/blockifier/src/blockifier/transaction_executor.rs line 137 at r1 (raw file):

        &mut self,
        _chunk: &[Transaction],
        _charge_fee: bool,

[noaov1]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 113 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Can be removed.

I think that this requires a python PR

[noaov1]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @meship-starkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 113 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

I think that this requires a python PR

It does not, my bad.

[meship-starkware]

Reviewable status: 3 of 4 files reviewed, 3 unresolved discussions (waiting on @noaov1 and @OriStarkware)

---

crates/blockifier/src/blockifier/transaction_executor.rs line 113 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

It does not, my bad.

Done.

---

crates/blockifier/src/blockifier/transaction_executor.rs line 120 at r1 (raw file):

            txs.chunks(self.config.concurrency_config.chunk_size)
                .fold_while(Vec::new(), |mut results, chunk| {
                    let chunk_results = self.execute_chunk(chunk, charge_fee);

Done.

---

crates/blockifier/src/blockifier/transaction_executor.rs line 137 at r1 (raw file):

        &mut self,
        _chunk: &[Transaction],
        _charge_fee: bool,

Done.

[noaov1]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

[noaov1]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)