-
Notifications
You must be signed in to change notification settings - Fork 107
chore(native_blockifier): delete TypedTransactionExecutionInfo #1983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python: https://reviewable.io/reviews/starkware-industries/starkware/35219
The rust PR is not blocking the python PR
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @noaov1)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
+ Coverage 78.38% 79.57% +1.18%
==========================================
Files 62 62
Lines 8855 9110 +255
Branches 8855 9110 +255
==========================================
+ Hits 6941 7249 +308
+ Misses 1475 1449 -26
+ Partials 439 412 -27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)
a discussion (no related file):
The new serialized object is successfully deserialized on python side after this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)
a discussion (no related file):
Previously, dorimedini-starkware wrote…
The new serialized object is successfully deserialized on python side after this change?
Yes!
d30263d
to
550ac05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)
This change is