Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

chore(native_blockifier): delete TypedTransactionExecutionInfo #1983

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

Yoni-Starkware
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware commented Jun 13, 2024

This change is Reviewable

Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python: https://reviewable.io/reviews/starkware-industries/starkware/35219

The rust PR is not blocking the python PR

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dorimedini-starkware and @noaov1)

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.57%. Comparing base (4505d16) to head (550ac05).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/native_blockifier/src/py_block_executor.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
+ Coverage   78.38%   79.57%   +1.18%     
==========================================
  Files          62       62              
  Lines        8855     9110     +255     
  Branches     8855     9110     +255     
==========================================
+ Hits         6941     7249     +308     
+ Misses       1475     1449      -26     
+ Partials      439      412      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

a discussion (no related file):
The new serialized object is successfully deserialized on python side after this change?


Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @noaov1)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

The new serialized object is successfully deserialized on python side after this change?

Yes!


Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@Yoni-Starkware Yoni-Starkware merged commit dc8e8c6 into main Jun 16, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants