-
Notifications
You must be signed in to change notification settings - Fork 107
chore(concurrency): add log messages to the concurrency module #1990
base: main
Are you sure you want to change the base?
Conversation
c346d99
to
b87b02b
Compare
Example log messages:
|
b87b02b
to
03bc0b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 62 62
Lines 8895 8895
Branches 8895 8895
=======================================
Hits 6993 6993
Misses 1455 1455
Partials 447 447 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be merged into the main; it's too many prints.
You can use it until the version is stable
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @barak-b-starkware, @meship-starkware, @noaov1, and @OriStarkware)
It might make better sense to add metrics for the batcher operations and individual threads. This way we will be able to monitor and debug performance without cluttering the logs. |
Co-authored-by: glihm <[email protected]>
This change is