Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

chore(concurrency): add log messages to the concurrency module #1990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avi-starkware
Copy link
Collaborator

@avi-starkware avi-starkware commented Jun 17, 2024

This change is Reviewable

@avi-starkware avi-starkware force-pushed the avi/concurrency/add-debug-messages branch from c346d99 to b87b02b Compare June 17, 2024 15:17
@avi-starkware
Copy link
Collaborator Author

Example log messages:

[ThreadId(10684)] Finished executing transaction index 1.
[ThreadId(10684)] Validating transaction index 1.
[ThreadId(10684)] Finished validating transaction index 1 with no abort.
[ThreadId(10684)] Executing transaction index 11.
[ThreadId(10684)] Finished executing transaction index 11.
[ThreadId(10684)] Executing transaction index 12.
[ThreadId(10684)] Finished executing transaction index 12.
[ThreadId(10684)] Validating transaction index 4.
[ThreadId(10684)] Aborted transaction index 4.
[ThreadId(10684)] Executing transaction index 4.

@avi-starkware avi-starkware changed the title chore(concurrency): add log messages to the concurrency module. chore(concurrency): add log messages to the concurrency module Jun 17, 2024
@avi-starkware avi-starkware force-pushed the avi/concurrency/add-debug-messages branch from b87b02b to 03bc0b9 Compare June 17, 2024 15:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (d924c79) to head (03bc0b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1990   +/-   ##
=======================================
  Coverage   78.61%   78.61%           
=======================================
  Files          62       62           
  Lines        8895     8895           
  Branches     8895     8895           
=======================================
  Hits         6993     6993           
  Misses       1455     1455           
  Partials      447      447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be merged into the main; it's too many prints.
You can use it until the version is stable

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @barak-b-starkware, @meship-starkware, @noaov1, and @OriStarkware)

@avi-starkware
Copy link
Collaborator Author

It might make better sense to add metrics for the batcher operations and individual threads. This way we will be able to monitor and debug performance without cluttering the logs.

gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants