This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
fix: remove workspace.lints #1995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In main repo we needed to bump rust_rules to a higher version in order to support stable rust 1.74, which `clap = 4.5.7` started requiring implicitely: clap-rs/clap@4b45d36. This rust_rules version has a bug with workspace.lints support, which is fixed in later versions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In main repo we needed to bump rust_rules to a higher version in order to support stable rust 1.74, which
clap = 4.5.7started requiring implicitely:clap-rs/clap@4b45d36.
This rust_rules version has a bug with workspace.lints support, which is fixed in later versions.
Note: I didn't put the docstring in blockifier/Cargo.toml because we don't want to mention bazel there.
This change is