Core Lib Documentation: fmt module
#6652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
Co-authored-by: Mathieu <[email protected]>
1 - Array module
|
This change is |
orizi
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TAdev0)
corelib/src/fmt.cairo line 230 at r2 (raw file):
/// `Debug` impl for fixed sized arrays of size 2 and above. /// Not starting from size 1 since we have a special case for 0.
This is useful to understand the code here.
you possibly only want to remove the /// and make it //.
Code quote:
/// `Debug` impl for fixed sized arrays of size 2 and above.
/// Not starting from size 1 since we have a special case for 0.
|
@orizi just address your comments. I restored the comments under |
orizi
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TAdev0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.