fix(helm): removed default values from templates

starkware-libs · Jul 16, 2024 · b249951 · b249951
1 parent f743fd4
commit b249951
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/deployments/helm/templates/deployment.yaml b/deployments/helm/templates/deployment.yaml
@@ -64,7 +64,7 @@ spec:
         {{- if not .Values.backup.enabled }}
         {{- with .Values.deployment.env }}
         env:
-          {{- toYaml . | nindent 12 }}
+          {{- toYaml . | nindent 10 }}
         {{- end }}
         args:
           - --config_file 
@@ -73,14 +73,14 @@ spec:
           - {{ .Values.base_layer_node_url }}
           {{- if .Values.p2p.enabled }}
           - --network.tcp_port
-          - {{ default "10000" .Values.p2p.config.networkTcpPort | quote }}
+          - {{ .Values.p2p.config.networkTcpPort | quote }}
           - --storage.db_config.path_prefix
-          - {{ default "data" .Values.p2p.config.storageDbConfigPathPrefix | quote }}
+          - {{ .Values.p2p.config.storageDbConfigPathPrefix | quote }}
           - --network.#is_none
-          - {{ default false .Values.p2p.config.networkIsNone | quote }}
+          - {{ .Values.p2p.config.networkIsNone | quote }}
           {{- if not .Values.p2p.bootstrap }}
           - --network.bootstrap_peer_multiaddr.#is_none
-          - {{ default false .Values.p2p.nodeConfig.bootstrapServer.multiaddrIsNone | quote }}
+          - {{ .Values.p2p.nodeConfig.bootstrapServer.multiaddrIsNone | quote }}
           - --network.bootstrap_peer_multiaddr
           - {{ include "p2p.bootstrapPeerMultiaddr" . | quote }}
           {{- end}}
@@ -103,7 +103,7 @@ spec:
           name: monitoring
         {{- end }}
         {{- if .Values.p2p.enabled }}
-        - containerPort: {{ default 10000 .Values.p2p.config.networkTcpPort }}
+        - containerPort: {{ .Values.p2p.config.networkTcpPort }}
           name: p2p
         {{- end }}
         volumeMounts:

diff --git a/deployments/helm/values.yaml b/deployments/helm/values.yaml
@@ -13,20 +13,19 @@ base_layer_node_url:
 starknet:
   # possible values: "mainnet.json, sepolia_testnet" and "sepolia_integration".
   preset: mainnet.json
-  additionalHeaders: # optional addtional headers for SN communication
 
 p2p:
   enabled: true
   # Set to true if node act as bootstrap server
   bootstrap: false
   # General config
   config:
-    # Optional - The node self port to listen | default "10000"
-    networkTcpPort:
-    # Optional - The node data path | default "data"
-    storageDbConfigPathPrefix:
-    # Optional - network.#is_none flag | default "false"
-    networkIsNone:
+    # Optional - The node self port to listen
+    networkTcpPort: 10000
+    # Optional - The node data path
+    storageDbConfigPathPrefix: data
+    # Optional - network.#is_none flag
+    networkIsNone: false
   # Config to include only if "bootstrap: false"
   nodeConfig:
     bootstrapServer: