Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage,config): open thin SD file #1249

Closed
wants to merge 1 commit into from

Conversation

dan-starkware
Copy link
Collaborator

@dan-starkware dan-starkware commented Oct 4, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1249 (c4f6151) into main (58dba19) will decrease coverage by 0.42%.
Report is 20 commits behind head on main.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   71.69%   71.28%   -0.42%     
==========================================
  Files          82       82              
  Lines        7851     7974     +123     
  Branches     7851     7974     +123     
==========================================
+ Hits         5629     5684      +55     
- Misses       1315     1378      +63     
- Partials      907      912       +5     
Files Coverage Δ
crates/papyrus_storage/src/db/mod.rs 83.00% <ø> (ø)
crates/papyrus_storage/src/mmap_file/mod.rs 80.73% <96.15%> (+13.29%) ⬆️
crates/papyrus_storage/src/utils.rs 56.25% <0.00%> (ø)
crates/papyrus_storage/src/lib.rs 64.70% <90.32%> (+5.50%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dan-starkware dan-starkware deleted the dan/storage/open-sd-file branch October 30, 2023 08:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant