-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(network): change streamed_data to streamed_bytes #1719
Conversation
a44719a
to
24f1df0
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ShahakShama and the rest of your teammates on Graphite |
24f1df0
to
5ba9907
Compare
b6c3bbb
to
7011c5f
Compare
0c5e6b5
to
16500a7
Compare
6769cac
to
83e4f7a
Compare
16500a7
to
2ea01f8
Compare
2ea01f8
to
3b60eb5
Compare
3b60eb5
to
333e6e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 15 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama)
crates/papyrus_network/src/streamed_bytes/mod.rs
line 66 at r2 (raw file):
} // TODO(shahak): Consider removing protocol_name from here.
remove
crates/papyrus_network/src/streamed_bytes/mod.rs
line 70 at r2 (raw file):
pub struct Config { pub session_timeout: Duration, // If we put multiple versions of the same protocol, they should be inserted sorted where the
this is an important comment. either find a way to deal with it or put it in a better place.
also consider using the Protocol enum from my PR somehow
aaa56f1
to
333e6e2
Compare
333e6e2
to
8c4e74e
Compare
* feat(network): convert network manager to work on bytes * refactor(network): move conversion unctions to module * feat(network): handle try_send error from net manager to subscriber (#1737)
* fix(network): uncomment p2p integration endpoint (#1771) * fix(network): move file and uncomment * fix(network): bench script works with new streamed_bytes --------- Co-authored-by: nagmo-starkware <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 37 files reviewed, 2 unresolved discussions (waiting on @nagmo-starkware)
crates/papyrus_network/src/streamed_bytes/mod.rs
line 66 at r2 (raw file):
Previously, nagmo-starkware wrote…
remove
Done.
crates/papyrus_network/src/streamed_bytes/mod.rs
line 70 at r2 (raw file):
Previously, nagmo-starkware wrote…
this is an important comment. either find a way to deal with it or put it in a better place.
also consider using the Protocol enum from my PR somehow
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 37 files reviewed, all discussions resolved
9cf7afc
to
99e00dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 37 files reviewed, all discussions resolved
This change is