refactor(config): move execution config to default #1828

eitanm-starkware · 2024-03-21T08:37:45Z

Pull Request type

Please check the type of change your PR introduces:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

Yes
No

Other information

This change is

codecov · 2024-03-21T08:46:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.27%. Comparing base (ed9c7ad) to head (a947c5c).
Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
+ Coverage   72.04%   73.27%   +1.22%     
==========================================
  Files         142      141       -1     
  Lines       20314    19969     -345     
  Branches    20314    19969     -345     
==========================================
- Hits        14636    14632       -4     
- Misses       3508     3569      +61     
+ Partials     2170     1768     -402

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yair-starkware

Reviewed 20 of 23 files at r1, all commit messages.
Reviewable status: 20 of 23 files reviewed, 5 unresolved discussions (waiting on @dan-starkware and @eitanm-starkware)

a discussion (no related file):
Why are there changes related to load_test?

config/default_config.json line 173 at r1 (raw file):

  },
  "rpc.execution_config.eth_fee_contract_address": {
    "description": "For executing transactions, the eth address to receive fees",

The ETH fee token contract address

Code quote:

For executing transactions, the eth address to receive fees

config/default_config.json line 183 at r1 (raw file):

  },
  "rpc.execution_config.strk_fee_contract_address": {
    "description": "For executing transactions, the strk address to receive fees",

The STRK fee token contract address

Code quote:

For executing transactions, the strk address to receive fees

crates/papyrus_execution/src/testing_instances.rs line 34 at r1 (raw file):

/// Creates ExecutionConfig for tests.
pub fn get_mock_execution_config() -> ExecutionConfig {

get_test_execution_config (mock is a different thing)

Can you also add a todo to make the execution tests use the default execution config?

Code quote:

get_mock_execution_config

crates/papyrus_rpc/src/lib.rs line 146 at r1 (raw file):

                &param.description[1..]
            );
        }

Why to do this?

Code quote:

        for param in execution_config_dump.values_mut() {
            param.description = format!(
                "For executing transactions, {}{}",
                param.description[0..1].to_lowercase(),
                &param.description[1..]
            );
        }

eitanm-starkware

Reviewable status: 13 of 23 files reviewed, 5 unresolved discussions (waiting on @dan-starkware and @yair-starkware)

a discussion (no related file):