Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update image tag for v0.3 #1864

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

dan-starkware
Copy link
Collaborator

@dan-starkware dan-starkware commented Apr 4, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@dan-starkware dan-starkware changed the base branch from main to v0.3 April 4, 2024 08:18
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.41%. Comparing base (aac83bb) to head (05e5f2c).

❗ Current head 05e5f2c differs from pull request most recent head f3585c0. Consider uploading reports for the commit f3585c0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             v0.3    #1864      +/-   ##
==========================================
+ Coverage   72.66%   76.41%   +3.75%     
==========================================
  Files         138      144       +6     
  Lines       19721    22399    +2678     
  Branches    19721    22399    +2678     
==========================================
+ Hits        14330    17117    +2787     
- Misses       3234     3653     +419     
+ Partials     2157     1629     -528     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ShahakShama
ShahakShama previously approved these changes Apr 8, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@dan-starkware dan-starkware merged commit 48e602f into v0.3 Apr 18, 2024
12 of 13 checks passed
@dan-starkware dan-starkware deleted the dan/deployments/v3-image branch April 18, 2024 07:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants