chore(helm): Add p2p support to helm chart

[idan-starkware]

• Modified the helm templates to support extra environment variables.
• Unified multiple svc creation into single service with multiple ports.

---

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.85%. Comparing base (c11022c) to head (7592d40).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   65.79%   65.85%   +0.05%     
==========================================
  Files         139      139              
  Lines       18286    18287       +1     
  Branches    18286    18287       +1     
==========================================
+ Hits        12032    12042      +10     
+ Misses       4964     4955       -9     
  Partials     1290     1290              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eranreshef-starkware]

why should backup be enabled for p2p mode?

[eranreshef-starkware]

no need to add svc suffix (no need to mention the resource type in the resource name)

[eranreshef-starkware]

since all these params have similar purpose and are all related, I suggest to nest them together:

bootstrap_server:
  ip:
  port:
  uid: 

also, we need to be consistent in the syntax formatting. either sneak_case or camelCase but not both

[eranreshef-starkware]

do we currently support service types other then NodePort?

[eranreshef-starkware]

the word extra in extraEnv implies that we have some default/pre-existing env vars we support. since we don't have such we don't need the extra part.

[idan-starkware]

deployments/helm/values.yaml line 42 at r7 (raw file):

Previously, eranreshef-starkware (Eran Reshef) wrote…

do we currently support service types other then NodePort?

Yes, you can use ClusterIP, LoadBalancer and NodePort.
We can later add additional support to specific loadbalancer configurations and service annotations but its not required for now.

[eranreshef-starkware]

deployments/helm/values.yaml line 42 at r7 (raw file):

Previously, idan-starkware (Idan Shamam) wrote…

Yes, you can use ClusterIP, LoadBalancer and NodePort.
We can later add additional support to specific loadbalancer configurations and service annotations but its not required for now.

so if I currently set this field to any value other then nodePort, will it work?

[eranreshef-starkware]

Reviewed 1 of 4 files at r3, 4 of 5 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @idan-starkware and @RoeiE-starkware)

[eranreshef-starkware]

Reviewed 5 of 5 files at r8, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @idan-starkware and @RoeiE-starkware)

---

deployments/helm/values.yaml line 35 at r8 (raw file):

      # Mandatory - The network.#is_none flag on the bootsrap server
      multiaddrIsNone: 
      # Mandatory - The bootstrap server to connect to, ip adress

address

Code quote:

adress