fix(transaction): add clone to declare tx #129
Conversation
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @meship-starkware)
crates/blockifier/src/transaction/account_transaction.rs line 66 at r1 (raw file):
/// Represents a paid Starknet transaction. #[derive(Debug, Clone)]
Please alphabetize
Code quote:
#[derive(Debug, Clone)]There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1)
crates/blockifier/src/transaction/account_transaction.rs line 66 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Please alphabetize
Hey, I see we have a lot of unordered Ddirives. Would you like me to fix this PR and add a task to fix all drives in the repo? (it can be writing a script that does it)
meship-starkware
force-pushed
the
meship/blockifier/add_clone_to_declare
branch
from
d66bb5c
to
c4f2a36
Compare
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)
meship-starkware
force-pushed
the
meship/blockifier/add_clone_to_declare
branch
from
c4f2a36
to
cc8166f
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
This change is