feat(blockifier): add call_contract cairo native syscall

[PearsonWhite]

Implements call_contract in NativeSyscallHandler.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

a discussion (no related file):
In test_track_resources, the logic for what we expect has changed. Now, I'm not sure if the result is expected or not and I need clarification.

Previously, both the outer call and the inner call had to be (Cairo1 | Native) for the inner tracked_resource to be SierraGas.
Now, long as the inner is (Cairo1 | Native) I think SierraGas should be used.

Currently, one case fails: when outer is Cairo0 and inner is Cairo1, SierraGas is expected, but CairoSteps is used.
I've added a complete table of the results here in csv format:

Code snippet:

outer , inner , expected_outer , expected_inner , actual_outer , actual_expected , pass/fail
Cairo0 , Cairo0 , CairoSteps , CairoSteps , CairoSteps , CairoSteps , pass
Cairo0 , Cairo1 , CairoSteps , SierraGas , CairoSteps , CairoSteps , failed <--- Should this fail? Or is it expected?
Cairo1 , Cairo0 , SierraGas , CairoSteps , SierraGas , CairoSteps , pass
Cairo1 , Cairo1 , SierraGas , SierraGas , SierraGas , SierraGas , pass
Cairo0 , Native , CairoSteps , SierraGas , CairoSteps , SierraGas , pass
Native , Cairo1 , SierraGas , SierraGas , SierraGas , SierraGas , pass
Native , Cairo0 , SierraGas , CairoSteps , SierraGas , CairoSteps , pass
Cairo1 , Native , SierraGas , SierraGas , SierraGas , SierraGas , pass
Native , Native , SierraGas , SierraGas , SierraGas , SierraGas , pass

---

[varex83]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @PearsonWhite)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 203 at r1 (raw file):

        let contract_address = ContractAddress::try_from(address)
            .expect("Failed to convert address argument to a ContractAddress");

Don't use expect, return runtime error instead

[varex83]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @PearsonWhite)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 225 at r1 (raw file):

            caller_address: self.contract_address,
            call_type: CallType::Call,
            initial_gas: u64::try_from(*remaining_gas).unwrap(),

Use expect instead of unwrap here

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 0 of 2 files reviewed, 3 unresolved discussions (waiting on @varex83)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 203 at r1 (raw file):

Previously, varex83 (Bohdan Ohorodnii) wrote…

Don't use expect, return runtime error instead

Done.

---

crates/blockifier/src/execution/native/syscall_handler.rs line 225 at r1 (raw file):

Previously, varex83 (Bohdan Ohorodnii) wrote…

Use expect instead of unwrap here

Done.

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.28%. Comparing base (e3165c4) to head (86e7eec).
Report is 406 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1548       +/-   ##
===========================================
+ Coverage   40.10%   69.28%   +29.17%     
===========================================
  Files          26      105       +79     
  Lines        1895    13771    +11876     
  Branches     1895    13771    +11876     
===========================================
+ Hits          760     9541     +8781     
- Misses       1100     3827     +2727     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware, @noaov1, and @Yoni-Starkware)

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

solved already

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[meship-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1, @PearsonWhite, and @Yoni-Starkware)

---

a discussion (no related file):
Please rebase to resolve conflicts.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[PearsonWhite]

Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @meship-starkware, @noaov1, and @Yoni-Starkware)

---

a discussion (no related file):

Previously, meship-starkware (Meshi Peled) wrote…

Please rebase to resolve conflicts.

done

[meship-starkware]

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

[Yoni-Starkware]

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @PearsonWhite)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 205 at r9 (raw file):

) {
    let cairo_steps_contract = cairo_steps_contract_version.get_test_contract();
    let sierra_gas_contract = FeatureContract::TestContract(CairoVersion::Cairo1);

Please fixturize this (add a case for native class)

Code quote:

sierra_gas_contract

[Yoni-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noaov1 and @PearsonWhite)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 32 at r9 (raw file):

#[test]
fn test_call_contract_that_panics() {

Please add a TODO to support this test once we support reverts

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[Yoni-Starkware]

Reviewed 1 of 2 files at r11, 3 of 3 files at r12, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @PearsonWhite)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 202 at r12 (raw file):

#[cfg_attr(
  feature = "cairo_native",
  test_case(CompilerBasedVersion::OldCairo1, CompilerBasedVersion::CairoVersion(CairoVersion::Native); "Cairo1_and_Native")

Thanks! non-blocking

Suggestion:

"OldCairo1_and_Native

[PearsonWhite]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 32 at r9 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please add a TODO to support this test once we support reverts

Added TODO

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 205 at r9 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please fixturize this (add a case for native class)

done

[PearsonWhite]

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 202 at r12 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Thanks! non-blocking

done

[Yoni-Starkware]

Reviewed 1 of 1 files at r13, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

[github-actions]

Artifacts upload triggered. View details here