chore: check that warnings are denied #1918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
giladchase
commented
Nov 10, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
crates/mempool/src/mempool.rs line 364 at r1 (raw file):
} pub struct dont_merge_me;
DONTMERGE
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
337de5c
to
c9436fe
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
e5a4764
to
9803790
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gilad/remove-clippy-sh #1918 +/- ##
==========================================================
- Coverage 76.50% 2.73% -73.77%
==========================================================
Files 373 107 -266
Lines 39965 13622 -26343
Branches 39965 13622 -26343
==========================================================
- Hits 30575 373 -30202
- Misses 7114 13232 +6118
+ Partials 2276 17 -2259 ☔ View full report in Codecov by Sentry. |
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
c9436fe
to
f3383ae
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
9803790
to
1658b69
Compare
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
2 times, most recently
from
9144e78
to
bcbdcba
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
1658b69
to
8efbf7b
Compare
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
bcbdcba
to
be8296c
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
2 times, most recently
from
a673216
to
e0cbd1b
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
scripts/run_tests.py
Outdated
| @@ -25,7 +25,7 @@ class BaseCommand(Enum): | |||
|
|
|||
| def cmd(self, crates: Set[str]) -> List[str]: | |||
| package_args = [] | |||
| operands = ["--", "-Dwarnings"] # "--" must be the first element. | |||
| operands = ["--", "-D", "warnings"] # "--" must be the first element. | |||
There was a problem hiding this comment.
The rustc flag needs to be a single argument: -Dwarnings. Splitting it into -D and warnings will cause the compiler to interpret these as separate flags. The line should be:
operands = ["--", "-Dwarnings"]Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
be8296c
to
c73f168
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
e0cbd1b
to
3bbcb23
Compare
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
2 times, most recently
from
ee13d10
to
1040e9b
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
3bbcb23
to
cd05e6b
Compare
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
1040e9b
to
f82884d
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
cd05e6b
to
c07bb28
Compare
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
dfc9bca
to
2ebc0c8
Compare
giladchase
force-pushed
the
gilad/check-warnings
branch
from
c07bb28
to
dae2f3b
Compare
giladchase
force-pushed
the
gilad/remove-clippy-sh
branch
from
2ebc0c8
to
2e7756a
Compare
DONTMERGE
giladchase
force-pushed
the
gilad/check-warnings
branch
from
dae2f3b
to
746edeb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DONTMERGE