feat(blockifier): add support for secp256k1 syscall for native

[varex83]

Should go after #1675 , #1813 , #1546 , #1545

Commit history will be changed in the future, so "feat: add support for keccak syscall" will be removed

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload triggered. View details here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pwhite/secp256r1@66e1652). Learn more about missing BASE report.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             pwhite/secp256r1    #1940   +/-   ##
===================================================
  Coverage                    ?   77.45%           
===================================================
  Files                       ?      385           
  Lines                       ?    40472           
  Branches                    ?    40472           
===================================================
  Hits                        ?    31349           
  Misses                      ?     6816           
  Partials                    ?     2307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[meship-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @Yoni-Starkware)

[Yoni-Starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware)

[avi-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @varex83)

---

crates/blockifier/src/execution/native/syscall_handler.rs line 642 at r2 (raw file):

        Secp256Point::new(x, y)
            .map(|op| op.map(|p| p.into()))
            .map_err(|e| self.handle_error(remaining_gas, e))

Let's be consistent with #1675 .

Suggestion:

        Secp256Point::new(x, y)
            .map(|option| option.map(|p| p.into()))
            .map_err(|err| self.handle_error(remaining_gas, err))

---

crates/blockifier/src/execution/native/syscall_handler.rs line 680 at r2 (raw file):

        Secp256Point::get_point_from_x(x, y_parity)
            .map(|op| op.map(|p| p.into()))
            .map_err(|e| self.handle_error(remaining_gas, e))

Let's be consistent with #1675 .

Suggestion:

        Secp256Point::get_point_from_x(x, y_parity)
            .map(|option| option.map(|p| p.into()))
            .map_err(|err| self.handle_error(remaining_gas, err))

[avi-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @varex83)

[avi-starkware]

Reviewed 2 of 2 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @varex83)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here