Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockifier): remove syscall selector from send_message_to_l1 #2022

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Nov 13, 2024

No description provided.

@varex83 varex83 added the native integration Related with the integration of Cairo Native into the Blockifier label Nov 13, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link
Contributor

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @varex83)

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (e3165c4) to head (90980d0).
Report is 370 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2022       +/-   ##
===========================================
+ Coverage   40.10%   69.00%   +28.89%     
===========================================
  Files          26      103       +77     
  Lines        1895    13562    +11667     
  Branches     1895    13562    +11667     
===========================================
+ Hits          760     9358     +8598     
- Misses       1100     3804     +2704     
- Partials       35      400      +365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meship-starkware meship-starkware merged commit 7aa546a into main Nov 13, 2024
12 checks passed
@meship-starkware meship-starkware deleted the bohdan/hotfix-send-msg-to-l1 branch November 13, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants