Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockifier): fix gas amounts for native #2061

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

varex83
Copy link
Contributor

@varex83 varex83 commented Nov 14, 2024

…cutor

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

@varex83 varex83 added the native integration Related with the integration of Cairo Native into the Blockifier label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.06%. Comparing base (e3165c4) to head (ee90bbe).
Report is 393 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2061       +/-   ##
===========================================
+ Coverage   40.10%   69.06%   +28.95%     
===========================================
  Files          26      105       +79     
  Lines        1895    13659    +11764     
  Branches     1895    13659    +11764     
===========================================
+ Hits          760     9433     +8673     
- Misses       1100     3823     +2723     
- Partials       35      403      +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @varex83)

@Yoni-Starkware Yoni-Starkware merged commit 5659c9c into main Nov 14, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
native integration Related with the integration of Cairo Native into the Blockifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants