-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix remote server creation macro #2179
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
- Coverage 40.10% 6.10% -34.00%
==========================================
Files 26 266 +240
Lines 1895 30804 +28909
Branches 1895 30804 +28909
==========================================
+ Hits 760 1882 +1122
- Misses 1100 28848 +27748
- Partials 35 74 +39 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_node/src/servers.rs
line 99 at r1 (raw file):
ComponentExecutionMode::LocalExecutionWithRemoteEnabled => { let local_client = $local_client .expect("Error: local client must be initialized in Remote execution mode.");
"Local client required to support inbound remote connections."
Code quote:
"Error: local client must be initialized in Remote execution mode."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_sequencer_node/src/servers.rs
line 99 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
"Local client required to support inbound remote connections."
"Local client should be set for inbound remote connections."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)
commit-id:fc4f30ad
4286cd6
to
b9950f4
Compare
No description provided.