Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix remote server creation macro #2179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Nov 19, 2024

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.10%. Comparing base (e3165c4) to head (b9950f4).
Report is 505 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #2179       +/-   ##
==========================================
- Coverage   40.10%   6.10%   -34.00%     
==========================================
  Files          26     266      +240     
  Lines        1895   30804    +28909     
  Branches     1895   30804    +28909     
==========================================
+ Hits          760    1882     +1122     
- Misses       1100   28848    +27748     
- Partials       35      74       +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_sequencer_node/src/servers.rs line 99 at r1 (raw file):

            ComponentExecutionMode::LocalExecutionWithRemoteEnabled => {
                let local_client = $local_client
                    .expect("Error: local client must be initialized in Remote execution mode.");

"Local client required to support inbound remote connections."

Code quote:

"Error: local client must be initialized in Remote execution mode."

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)


crates/starknet_sequencer_node/src/servers.rs line 99 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

"Local client required to support inbound remote connections."

"Local client should be set for inbound remote connections."

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants