refactor(blockifier): rename transaction_receipt t… #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoni-Starkware
force-pushed
the
yoni/blockifier/tx-receipt
branch
from
7c59a96
to
51e436a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
+ Coverage 76.77% 76.92% +0.15%
==========================================
Files 318 318
Lines 34565 34700 +135
Branches 34565 34700 +135
==========================================
+ Hits 26536 26693 +157
- Misses 5739 5741 +2
+ Partials 2290 2266 -24 ☔ View full report in Codecov by Sentry. |
meship-starkware
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Yoni-Starkware
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o receipt
This change is