-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(fee): implement methods on resource bounds #600
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
==========================================
- Coverage 75.83% 75.72% -0.12%
==========================================
Files 352 85 -267
Lines 37423 10984 -26439
Branches 37423 10984 -26439
==========================================
- Hits 28381 8318 -20063
+ Misses 6726 2242 -4484
+ Partials 2316 424 -1892 ☔ View full report in Codecov by Sentry. |
5727a35
to
d190710
Compare
58cff48
to
9fb9e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions
crates/blockifier/src/transaction/objects.rs
line 585 at r1 (raw file):
type FeeCheckResult<T> = Result<T, FeeCheckError>; // Better name for the trait?
?
Code quote:
// Better name for the trait?
crates/blockifier/src/transaction/objects.rs
line 621 at r1 (raw file):
l1_data_gas, }) => { // Does the order matter?
If more than one resource has been exceeded, the user won't be able to know that.
Maybe instead we should add only one new error variant which will hold the gas vector consumed by the user and the resources he signed on. If more than one resource has exceeded, he could see that
Code quote:
/ Does the order matter?
d190710
to
766fea5
Compare
9fb9e94
to
43c559a
Compare
766fea5
to
3fd60c3
Compare
43c559a
to
3b621e3
Compare
561d8b3
to
9425ecb
Compare
3b621e3
to
a60c744
Compare
9425ecb
to
400a9bc
Compare
a60c744
to
aa03052
Compare
400a9bc
to
0ca0d84
Compare
aa03052
to
a682b71
Compare
0ca0d84
to
d701861
Compare
a682b71
to
00d120b
Compare
d701861
to
34a4dec
Compare
00d120b
to
c4b9af3
Compare
34a4dec
to
3b3dad4
Compare
c4b9af3
to
b20fe3c
Compare
3b3dad4
to
c2c6c6d
Compare
b20fe3c
to
fa26d2d
Compare
c2c6c6d
to
49c75ef
Compare
fa26d2d
to
74b7e19
Compare
49c75ef
to
a1450e0
Compare
74b7e19
to
b8e6fb8
Compare
a1450e0
to
3a77da9
Compare
b8e6fb8
to
5a131b2
Compare
3a77da9
to
2153557
Compare
5a131b2
to
2b2bf85
Compare
2153557
to
ed50e99
Compare
2b2bf85
to
badb3d6
Compare
ed50e99
to
db8074f
Compare
badb3d6
to
104b7ad
Compare
70b5a37
to
a64e601
Compare
104b7ad
to
29d9f97
Compare
a64e601
to
f35a01b
Compare
29d9f97
to
be7a1da
Compare
be7a1da
to
1a33a5f
Compare
f35a01b
to
c65f0b9
Compare
1a33a5f
to
f357376
Compare
This change is