Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(fee): implement methods on resource bounds #600

Closed
wants to merge 1 commit into from

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 26, 2024

This change is Reviewable

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 61.05263% with 37 lines in your changes missing coverage. Please review.

Project coverage is 75.72%. Comparing base (c65f0b9) to head (f357376).

Files with missing lines Patch % Lines
crates/blockifier/src/transaction/objects.rs 44.64% 31 Missing ⚠️
crates/starknet_api/src/transaction.rs 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   75.83%   75.72%   -0.12%     
==========================================
  Files         352       85     -267     
  Lines       37423    10984   -26439     
  Branches    37423    10984   -26439     
==========================================
- Hits        28381     8318   -20063     
+ Misses       6726     2242    -4484     
+ Partials     2316      424    -1892     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 5727a35 to d190710 Compare August 27, 2024 07:25
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/impl_methods branch from 58cff48 to 9fb9e94 Compare August 27, 2024 07:25
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions


crates/blockifier/src/transaction/objects.rs line 585 at r1 (raw file):

type FeeCheckResult<T> = Result<T, FeeCheckError>;
// Better name for the trait?

?

Code quote:

// Better name for the trait?

crates/blockifier/src/transaction/objects.rs line 621 at r1 (raw file):

                l1_data_gas,
            }) => {
                // Does the order matter?

If more than one resource has been exceeded, the user won't be able to know that.
Maybe instead we should add only one new error variant which will hold the gas vector consumed by the user and the resources he signed on. If more than one resource has exceeded, he could see that

Code quote:

/ Does the order matter?

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from d190710 to 766fea5 Compare August 28, 2024 09:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/impl_methods branch from 9fb9e94 to 43c559a Compare August 28, 2024 09:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 766fea5 to 3fd60c3 Compare August 28, 2024 13:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/impl_methods branch from 43c559a to 3b621e3 Compare August 28, 2024 13:21
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch 2 times, most recently from 561d8b3 to 9425ecb Compare September 1, 2024 05:31
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 9425ecb to 400a9bc Compare September 1, 2024 05:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 400a9bc to 0ca0d84 Compare September 1, 2024 08:16
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 0ca0d84 to d701861 Compare September 1, 2024 10:59
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from d701861 to 34a4dec Compare September 3, 2024 06:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 34a4dec to 3b3dad4 Compare September 3, 2024 13:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 3b3dad4 to c2c6c6d Compare September 3, 2024 13:45
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from c2c6c6d to 49c75ef Compare September 3, 2024 13:51
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 49c75ef to a1450e0 Compare September 3, 2024 15:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from a1450e0 to 3a77da9 Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 3a77da9 to 2153557 Compare September 4, 2024 07:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from 2153557 to ed50e99 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from ed50e99 to db8074f Compare September 4, 2024 11:09
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch 2 times, most recently from 70b5a37 to a64e601 Compare September 4, 2024 13:35
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/remove_some_more branch from a64e601 to f35a01b Compare September 5, 2024 07:17
@nimrod-starkware nimrod-starkware changed the base branch from nimrod/resources_enum/remove_some_more to graphite-base/600 September 5, 2024 11:07
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/600 to main September 5, 2024 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant