Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: derive serialize and deserialize for chain info #97

Merged

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 25, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Derive Serialize/Deserialize towards Papyrus config on these structs.

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 25, 2024

Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)


crates/blockifier/src/context.rs line 72 at r1 (raw file):

}

#[derive(Clone, Debug, Deserialize, PartialEq, Serialize)]

Why it's needed?

Code quote:

 PartialEq,

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)


crates/blockifier/src/context.rs line 72 at r1 (raw file):

Previously, MohammadNassar1 (mohammad-starkware) wrote…

Why it's needed?

The struct StatefulTransactionValidatorConfig in the blockifier will use this struct in #99.
It is used for testing. This derive is not heavy, so there is no need to limit it for testing only.

@ArniStarkware ArniStarkware force-pushed the arni/mempool/code_dedup/chain_info/derive_serialize branch from b544021 to 8b24eca Compare July 31, 2024 06:55
Copy link
Contributor Author

ArniStarkware commented Jul 31, 2024

Merge activity

@ArniStarkware ArniStarkware merged commit d1798bc into main Jul 31, 2024
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
@ArniStarkware ArniStarkware deleted the arni/mempool/code_dedup/chain_info/derive_serialize branch August 13, 2024 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants