Fixes for installation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can build the Dockerfile and run the script from within a container. It should be self-contained. |
spapinistarkware
suggested changes
Jul 13, 2021
| @@ -103,7 +103,10 @@ def main(): | |||
| '/usr/bin', | |||
| '/usr/local/bin', | |||
| ] | |||
| python_exec = shutil.which(args.python, path=':'.join(lookup_paths)) | |||
| python_exec = ( | |||
There was a problem hiding this comment.
Can you add the corrent lookup path to the list above instead?
There was a problem hiding this comment.
Why try to anticipate every path that the user may be using? Mine was in ~/.pyenv/shims
| @@ -71,7 +71,10 @@ def main(): | |||
| d = d.split(':')[-1] | |||
| metadata_files = glob.glob(os.path.join(d, '*/METADATA')) | |||
| for filename in metadata_files: | |||
| licenses += extract_licenses(filename) | |||
| try: | |||
There was a problem hiding this comment.
Can you explain why this fails, and on what filename?
There was a problem hiding this comment.
It fails if the filename is a directory (IsADirectoryError), in my case it was specifically python3.7/pip_chardet/chardet/METADATA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My system:
In addition to the small changes in this PR, these are the steps I had to take to complete installation and run the
public_generate_perpetual_config_hash.pyscript: