Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Update config.toml #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizatkinson
Copy link

@lizatkinson lizatkinson commented Mar 17, 2023

Above configuration file uses the -Wall, -Wextra, and -Wpedantic flags to enable all available warning messages, and the -Wfuture-incompatible, -Wnonstandard-style, and -Wunused flags to enable specific warnings for code that may become incompatible with future versions of Rust, code that deviates from standard Rust style guidelines, and unused code elements, respectively. Finally, the -Dclippy::unwrap_used flag enables warnings for the use of the unwrap() method.


This change is Reviewable

Above configuration file uses the -Wall, -Wextra, and -Wpedantic flags to enable all available warning messages, and the -Wfuture-incompatible, -Wnonstandard-style, and -Wunused flags to enable specific warnings for code that may become incompatible with future versions of Rust, code that deviates from standard Rust style guidelines, and unused code elements, respectively. Finally, the -Dclippy::unwrap_used flag enables warnings for the use of the unwrap() method.
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I apologize for not getting back to you sooner.

I think we should stick to deny rather than warn.

As for the new lints, I think that:

  • all - means all lints that are on by default, so it shouldn't add coverage, right?
  • extra - I'm not familiar with it, can you please give a reference to a corresponding documentation?
  • pedantic - this is a Clippy lint group/category (so should probably be clippy::pedantic)

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lizatkinson)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants