No penidng block subscription option for txStatus #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
reviewed
Dec 23, 2024
There was a problem hiding this comment.
So now no starknet_subscribe* methods accept a "pending" block ID? Perhaps it would then make sense to introduce a new schema definition that accepts all block IDs except "pending", which would obsolesce the CALL_ON_PENDING error. This would reduce the number of spec lines.
Just wanted to mention this, not saying it has to be done, it's already valid.
Also, there's a typo in the title, it could creep into the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.