-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range check small table #167
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ohad-starkware and the rest of your teammates on Graphite |
fde4539
to
2bf099c
Compare
0c56d4c
to
442fdf9
Compare
2bf099c
to
226d903
Compare
442fdf9
to
badf610
Compare
226d903
to
7957833
Compare
badf610
to
e7c65df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)
stwo_cairo_prover/crates/prover/src/components/memory/id_to_f252/component.rs
line 180 at r1 (raw file):
let interaction_log_sizes = chain!( vec![self.big_log_size; SECURE_EXTENSION_DEGREE * (N_M31_IN_FELT252 / 2 + 1)], vec![self.small_log_size; SECURE_EXTENSION_DEGREE * (N_M31_IN_SMALL_FELT252 / 2 + 1)]
change this to div_ceil
Code quote:
N_M31_IN_SMALL_FELT252 / 2
7957833
to
3890805
Compare
e7c65df
to
ffc37d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/components/memory/id_to_f252/component.rs
line 180 at r1 (raw file):
Previously, shaharsamocha7 wrote…
change this to div_ceil
ok but the line drop is on you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)
3890805
to
c851891
Compare
ffc37d2
to
da16291
Compare
Merge activity
|
da16291
to
d5334d2
Compare
This change is