Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range check small table #167

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

ohad-starkware
Copy link
Contributor

@ohad-starkware ohad-starkware commented Nov 13, 2024

This change is Reviewable

This was referenced Nov 13, 2024
Copy link
Contributor Author

ohad-starkware commented Nov 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ohad-starkware and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)


stwo_cairo_prover/crates/prover/src/components/memory/id_to_f252/component.rs line 180 at r1 (raw file):

        let interaction_log_sizes = chain!(
            vec![self.big_log_size; SECURE_EXTENSION_DEGREE * (N_M31_IN_FELT252 / 2 + 1)],
            vec![self.small_log_size; SECURE_EXTENSION_DEGREE * (N_M31_IN_SMALL_FELT252 / 2 + 1)]

change this to div_ceil

Code quote:

N_M31_IN_SMALL_FELT252 / 2

Copy link
Contributor Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/components/memory/id_to_f252/component.rs line 180 at r1 (raw file):

Previously, shaharsamocha7 wrote…

change this to div_ceil

ok but the line drop is on you

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ohad-starkware)

Copy link
Contributor Author

ohad-starkware commented Nov 14, 2024

Merge activity

  • Nov 14, 8:43 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 8:45 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 14, 8:54 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 14, 8:54 AM EST: A user merged this pull request with Graphite.

@ohad-starkware ohad-starkware changed the base branch from ohad/verify_and_ret to graphite-base/167 November 14, 2024 13:43
@ohad-starkware ohad-starkware changed the base branch from graphite-base/167 to main November 14, 2024 13:43
@ohad-starkware ohad-starkware merged commit 92ac0a6 into main Nov 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants