range_check_19

[ohad-starkware]

This change is 

[ohad-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• generic opcode and vm constraint #182
• range_check_19 #180 👈 (View in Graphite)
• handle no inputs #179
• code refactoring and component ordering #177
• moved stuff to air_rs #178
• packed types for generic opcode #176
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shaharsamocha7]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ohad-starkware)

---

a discussion (no related file):
A suggestion for improvement, not sure that we want to implement it though:

We can add the rc19 relation to rc_9_9 using two more multiplicities columns

---

stwo_cairo_prover/crates/prover/src/cairo_air/mod.rs line 20 at r1 (raw file):

const LOG_MAX_ROWS: u32 = 20;

const IS_FIRST_LOG_SIZES: [u32; 6] = [4, 6, 7, 14, 19, 18];

Q: Can we sort this array in any order?

Code quote:

const IS_FIRST_LOG_SIZES: [u32; 6] = [4, 6, 7, 14, 19, 18];

[ohad-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/mod.rs line 20 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Q: Can we sort this array in any order?

sorted alphabetically