fix(ui): TE-XXXX quota negative value fix (#1762)

* fix(ui): TE-XXXX quota negative value fix * detection check fix
startreedata · Jan 21, 2025 · a8ad5a6 · a8ad5a6
1 parent 5b3ebc6
commit a8ad5a6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/.../src/app/components/app-bar/app-bar-config-provider/app-bar-config-provider.component.tsx b/.../src/app/components/app-bar/app-bar-config-provider/app-bar-config-provider.component.tsx
@@ -100,12 +100,16 @@ export const AppBarConfigProvider: FunctionComponent<AppBarConfigProviderProps>
                     startTime: startOfMonth,
                 });
                 setRemainingQuota({
-                    notification:
+                    notification: Math.max(
                         taskQuotasConfiguration.maximumNotificationTasksPerMonth! -
-                        notificationUsage.count,
-                    detection:
+                            notificationUsage.count,
+                        0
+                    ),
+                    detection: Math.max(
                         taskQuotasConfiguration.maximumDetectionTasksPerMonth! -
-                        detectionUsage.count,
+                            detectionUsage.count,
+                        0
+                    ),
                 });
             } catch (e) {
                 notifyIfErrors(

diff --git a/thirdeye-ui/src/app/components/create-alert-modal/create-alert-modal.component.tsx b/thirdeye-ui/src/app/components/create-alert-modal/create-alert-modal.component.tsx
@@ -71,10 +71,7 @@ export const CreateAlertModal: FunctionComponent<CreateAlertModalModalProps> =
         }, [defaultCron]);
 
         const checkQuota = (): void => {
-            if (
-                remainingQuota?.notification &&
-                remainingQuota?.notification <= 0
-            ) {
+            if (remainingQuota?.detection && remainingQuota?.detection <= 0) {
                 showDialog({
                     type: DialogType.ALERT,
                     contents: (