Add unit tests in Routes

staticka · Nov 9, 2024 · d6f345d · d6f345d
1 parent 0ff6451
commit d6f345d
Show file tree

Hide file tree

Showing 9 changed files with 353 additions and 58 deletions.
diff --git a/src/Check.php b/src/Check.php
@@ -50,15 +50,17 @@ public function errors()
      */
     public function firstError()
     {
-        if (! $this->errors)
+        $result = null;
+
+        if ($this->errors)
         {
-            return null;
-        }
+            /** @var string[][] */
+            $values = array_values($this->errors);
 
-        /** @var string[][] */
-        $values = array_values($this->errors);
+            $result = $values[0][0];
+        }
 
-        return (string) $values[0][0];
+        return $result;
     }
 
     /**
@@ -93,12 +95,14 @@ public function rules($data)
      */
     public function setError($key, $text)
     {
-        if (! isset($this->errors[$key]))
+        $exists = array_key_exists($key, $this->errors);
+
+        if (! $exists)
         {
             $this->errors[$key] = array();
         }
 
-        array_push($this->errors[$key], $text);
+        $this->errors[$key][] = $text;
 
         return $this;
     }

diff --git a/src/Checks/PageCheck.php b/src/Checks/PageCheck.php
@@ -58,10 +58,12 @@ public function valid(array $data = null)
     {
         $valid = parent::valid($data);
 
+        // @codeCoverageStartIgnore
         if (! $data || ! $valid)
         {
             return false;
         }
+        // @codeCoverageEndIgnore
 
         /** @var string */
         $name = $data['name'];

diff --git a/src/Helpers/FieldHelper.php → src/Helpers/DataHelper.php b/src/Helpers/FieldHelper.php → src/Helpers/DataHelper.php
@@ -7,7 +7,7 @@
  *
  * @author Rougin Gutib <[email protected]>
  */
-class FieldHelper
+class DataHelper
 {
     /**
      * @param string[]             $fields

diff --git a/src/Helpers/LinkHelper.php b/src/Helpers/LinkHelper.php
@@ -14,17 +14,17 @@ class LinkHelper extends Staticka
     /**
      * @var array<string, string>
      */
-    protected $server;
+    protected $server = array();
 
     /**
      * @param string                $base
      * @param array<string, string> $server
      */
     public function __construct($base, $server = array())
     {
-        parent::__construct($base);
-
         $this->server = $server;
+
+        parent::__construct($base);
     }
 
     /**

diff --git a/src/Routes/Pages.php b/src/Routes/Pages.php
@@ -6,7 +6,7 @@
 use Psr\Http\Message\ServerRequestInterface;
 use Staticka\Depots\PageDepot;
 use Staticka\Expresso\Checks\PageCheck;
-use Staticka\Expresso\Helpers\FieldHelper;
+use Staticka\Expresso\Helpers\DataHelper;
 use Staticka\Expresso\Plate;
 
 /**
@@ -74,7 +74,7 @@ public function show($id, PageDepot $page, Plate $plate)
 
         $item['page'] = $data;
 
-        $item['data'] = FieldHelper::toJson($fields, $data);
+        $item['data'] = DataHelper::toJson($fields, $data);
 
         /** @var \Psr\Http\Message\ResponseInterface */
         return $plate->view('editor', $item);

diff --git a/tests/AppTest.php b/tests/AppTest.php
@@ -19,24 +19,7 @@ class AppTest extends Testcase
      */
     public function doSetUp()
     {
-        $path = __DIR__ . '/Fixture';
-
-        $app = new Express;
-
-        $app->setAppUrl('http://localhost:3977');
-        $app->setSiteUrl('http://localhost:3978');
-        $app->setRootPath($path);
-
-        $app->setBuildPath($path . '/build');
-        $app->setConfigPath($path . '/config');
-        $app->setPagesPath($path . '/pages');
-        $app->setBuildPath($path . '/build');
-        $app->setTimezone('Asia/Manila');
-
-        $plates = __DIR__ . '/../app/plates';
-        $app->setPlatesPath($plates);
-
-        $this->app = $app->setFields(array());
+        $this->app = $this->setApp();
     }
 
     /**
@@ -53,18 +36,6 @@ public function test_fixed_app_path()
         $this->assertEquals($expected, $actual);
     }
 
-    /**
-     * @return void
-     */
-    public function test_pages_page()
-    {
-        $this->setRequest('GET', '/pages');
-
-        $this->app->run();
-
-        $this->expectOutputRegex('/Create New Page/');
-    }
-
     /**
      * @return void
      */
@@ -76,18 +47,4 @@ public function test_welcome_page()
 
         $this->expectOutputRegex('/Welcome to Expresso!/');
     }
-
-    /**
-     * @param string $method
-     * @param string $uri
-     *
-     * @return void
-     */
-    protected function setRequest($method, $uri)
-    {
-        $_SERVER['REQUEST_METHOD'] = $method;
-        $_SERVER['REQUEST_URI'] = $uri;
-        $_SERVER['SERVER_NAME'] = 'localhost';
-        $_SERVER['SERVER_PORT'] = '8000';
-    }
 }
diff --git a/tests/Routes/BuildTest.php b/tests/Routes/BuildTest.php
@@ -0,0 +1,43 @@
+<?php
+
+namespace Staticka\Expresso\Routes;
+
+use Staticka\Expresso\Testcase;
+
+/**
+ * @package Staticka
+ *
+ * @author Rougin Gutib <[email protected]>
+ */
+class BuildTest extends Testcase
+{
+    /**
+     * @var \Staticka\Expresso\Express
+     */
+    protected $app;
+
+    /**
+     * @return void
+     */
+    public function doSetUp()
+    {
+        $this->app = $this->setApp();
+    }
+
+    /**
+     * @return void
+     */
+    public function test_build_without_staticka_yml()
+    {
+        $expected = '"staticka.yml" not yet created';
+
+        /** @var string */
+        $expected = json_encode($expected);
+
+        $this->setRequest('POST', '/build');
+
+        $this->app->run();
+
+        $this->expectOutputString($expected);
+    }
+}