Skip to content

Commit

Permalink
Remove correlationId from PseudoFuncConfigs
Browse files Browse the repository at this point in the history
  • Loading branch information
Skaar, Bjørn-Andre committed Feb 6, 2024
1 parent cdfa6b6 commit 27ab978
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ public static class Builder {

private Collection<PseudoKeyset> keysets;

private String correlationId;

public Builder secrets(Collection<PseudoSecret> secrets) {
this.secrets = secrets;
return this;
Expand All @@ -90,15 +88,10 @@ public Builder keysets(Collection<PseudoKeyset> keysets) {
return this;
}

public Builder correlationId(String correlationId) {
this.correlationId = correlationId;
return this;
}

public FieldPseudonymizer build() {
Objects.requireNonNull(secrets, "PseudoSecrets can't be null");
Objects.requireNonNull(rules, "PseudoFuncRule collection can't be null");
return new FieldPseudonymizer(new PseudoFuncs(rules, secrets, keysets, correlationId));
return new FieldPseudonymizer(new PseudoFuncs(rules, secrets, keysets));
}
}
}
12 changes: 3 additions & 9 deletions src/main/java/no/ssb/dlp/pseudo/core/func/PseudoFuncs.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,15 @@ public class PseudoFuncs {

//TODO: Validate that all required secrets are available
public PseudoFuncs(Collection<PseudoFuncRule> rules, Collection<PseudoSecret> pseudoSecrets,
Collection<PseudoKeyset> keysets, String correlationId) {
Map<PseudoFuncRule, PseudoFuncConfig> ruleToPseudoFuncConfigs = initPseudoFuncConfigs(rules, pseudoSecrets, keysets, correlationId);
Collection<PseudoKeyset> keysets) {
Map<PseudoFuncRule, PseudoFuncConfig> ruleToPseudoFuncConfigs = initPseudoFuncConfigs(rules, pseudoSecrets, keysets);
rules.forEach(rule -> ruleToFuncMap.put(rule, PseudoFuncFactory.create(ruleToPseudoFuncConfigs.get(rule))));
}

// TODO: Move these init functions elsewhere?
static Map<PseudoFuncRule, PseudoFuncConfig> initPseudoFuncConfigs(Collection<PseudoFuncRule> pseudoRules,
Collection<PseudoSecret> pseudoSecrets,
Collection<PseudoKeyset> pseudoKeysets,
String correlationId) {
Collection<PseudoKeyset> pseudoKeysets) {

Map<String, PseudoSecret> pseudoSecretsMap = pseudoSecrets.stream().collect(
Collectors.toMap(PseudoSecret::getName, Function.identity()));
Expand All @@ -54,7 +53,6 @@ static Map<PseudoFuncRule, PseudoFuncConfig> initPseudoFuncConfigs(Collection<Ps
Function.identity(),
rule -> {
PseudoFuncConfig funcConfig = PseudoFuncConfigFactory.get(rule.getFunc());
funcConfig.add(Param.CORRELATION_ID, correlationId);

if (FpeFunc.class.getName().equals(funcConfig.getFuncImpl())) {
enrichLegacyFpeFuncConfig(funcConfig, pseudoSecretsMap);
Expand Down Expand Up @@ -173,8 +171,4 @@ public PseudoFuncConfigException(String message, Exception e) {
super(message, e);
}
}

public static final class Param {
public static final String CORRELATION_ID = "correlationId";
}
}

0 comments on commit 27ab978

Please sign in to comment.