Merge pull request #123 from statisticsnorway/122-rounding-00-to-no-d…

…igits-leaves-digits-with-round_data

what if n is zero duh

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "dapla-statbank-client"
-version = "1.2.0"
+version = "1.2.1"
 description = "Handles data transfer Statbank <-> Dapla for Statistics Norway"
 authors = ["Statistics Norway", "Carl F. Corneil <[email protected]>"]
 license = "MIT"

src/statbank/uttrekk.py

@@ -326,9 +326,9 @@ def _round_up(n: float, decimals: int = 0) -> str:
             ctx.rounding = ROUND_HALF_UP
             if pd.isna(n):
                 result: str = ""
-            elif decimals and n:
+            elif decimals and (n or n == 0):
                 result = str(round(Decimal(n), decimals))
-            elif n:
+            elif n or n == 0:
                 result = str(Decimal(n).to_integral_value())
             else:
                 result = str(n)

tests/test_statbank.py

@@ -25,6 +25,10 @@
 from statbank.uttrekk import StatbankUttrekksBeskrivelse
 
 
+def test_round_up_zero():
+    assert StatbankUttrekksBeskrivelse._round_up(0.0, 0) == "0"  # noqa: SLF001
+
+
 def fake_user():
     return "SSB-person-456"